From 5972613b7a0b7933d2736ea6190f652263ad37a3 Mon Sep 17 00:00:00 2001 From: Jez Ng Date: Wed, 18 Jan 2012 11:08:28 +0800 Subject: Handle special keys with keydown handler. (Hopefully) closes #427. --- vimiumFrontend.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/vimiumFrontend.js b/vimiumFrontend.js index 8d924ac7..693d1232 100644 --- a/vimiumFrontend.js +++ b/vimiumFrontend.js @@ -408,9 +408,10 @@ function onKeydown(event) { var keyChar = ""; - // handle modifiers being pressed.don't handle shiftKey alone (to avoid / being interpreted as ? - if (event.metaKey && event.keyCode > 31 || event.ctrlKey && event.keyCode > 31 || - event.altKey && event.keyCode > 31) { + // handle special keys, and normal input keys with modifiers being pressed. don't handle shiftKey alone (to + // avoid / being interpreted as ? + if (((event.metaKey || event.ctrlKey || event.altKey) && event.keyCode > 31) + || event.keyIdentifier.slice(0, 2) != "U+") { keyChar = getKeyChar(event); if (keyChar != "") { // Again, ignore just modifiers. Maybe this should replace the keyCode>31 condition. -- cgit v1.2.3