From 58e332fe942d01c8f4633b3415c460f678b2c75b Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Fri, 4 Mar 2016 10:21:13 +0000 Subject: Use role/link to make command names clickable. --- content_scripts/link_hints.coffee | 1 - pages/help_dialog.coffee | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/content_scripts/link_hints.coffee b/content_scripts/link_hints.coffee index e74653f2..c8f9b6f9 100644 --- a/content_scripts/link_hints.coffee +++ b/content_scripts/link_hints.coffee @@ -205,7 +205,6 @@ class LinkHintsMode if (element.hasAttribute("onclick") or element.getAttribute("role")?.toLowerCase() in ["button", "link"] or element.getAttribute("class")?.toLowerCase().indexOf("button") >= 0 or - element.getAttribute("class")?.indexOf("vimiumClickable") >= 0 or element.getAttribute("contentEditable")?.toLowerCase() in ["", "contentEditable", "true"]) isClickable = true diff --git a/pages/help_dialog.coffee b/pages/help_dialog.coffee index 0589e379..0da4977b 100644 --- a/pages/help_dialog.coffee +++ b/pages/help_dialog.coffee @@ -42,7 +42,7 @@ HelpDialog = # clicked with link hints). for element in @dialogElement.getElementsByClassName "commandName" do (element) -> - element.classList.add "vimiumClickable" + element.setAttribute "role", "link" element.addEventListener "click", -> commandName = element.textContent.replace("(","").replace ")", "" chrome.runtime.sendMessage handler: "copyToClipboard", data: commandName -- cgit v1.2.3