From 5745bb344959a61297fc16e00bb6de0a2a8744d9 Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Sun, 1 Apr 2018 07:46:49 +0100 Subject: Disable click listener detection and bump to v1.63.3. --- README.md | 2 ++ content_scripts/injected.coffee | 3 +++ content_scripts/link_hints.coffee | 5 +++-- manifest.json | 2 +- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 54eb7f94..9292c3b9 100644 --- a/README.md +++ b/README.md @@ -185,6 +185,8 @@ In `master` (not yet released) - Fix [#2958](https://github.com/philc/vimium/issues/2958#issuecomment-366488659), link hints broken for `target="_blank"` links. - 1.63.2 (Firefox only): - Fix [#2962](https://github.com/philc/vimium/issues/2962), find mode broken on Firefox Quantum. +- 1.63.3: + - Fix [#2997](https://github.com/philc/vimium/issues/2997), Vimium's DOM injection breaks Google Pay site. 1.62 (2017-12-09) diff --git a/content_scripts/injected.coffee b/content_scripts/injected.coffee index 5b614763..b943f2fc 100644 --- a/content_scripts/injected.coffee +++ b/content_scripts/injected.coffee @@ -1,3 +1,6 @@ +# NOTE(smblott) Disabled pending resolution of #2997. +return + # The code in `injectedCode()`, below, is injected into the page's own execution context. # # This is based on method 2b here: http://stackoverflow.com/a/9517879, and diff --git a/content_scripts/link_hints.coffee b/content_scripts/link_hints.coffee index 020ff1c7..849aa4c5 100644 --- a/content_scripts/link_hints.coffee +++ b/content_scripts/link_hints.coffee @@ -706,8 +706,9 @@ LocalHints = isClickable = true reason = "Open." - # Detect elements with "click" listeners installed with `addEventListener()`. - isClickable ||= element.hasAttribute "_vimium-has-onclick-listener" + # NOTE(smblott) Disabled pending resolution of #2997. + # # Detect elements with "click" listeners installed with `addEventListener()`. + # isClickable ||= element.hasAttribute "_vimium-has-onclick-listener" # An element with a class name containing the text "button" might be clickable. However, real clickables # are often wrapped in elements with such class names. So, when we find clickables based only on their diff --git a/manifest.json b/manifest.json index a1951247..da08fd59 100644 --- a/manifest.json +++ b/manifest.json @@ -1,7 +1,7 @@ { "manifest_version": 2, "name": "Vimium", - "version": "1.63.2", + "version": "1.63.3", "description": "The Hacker's Browser. Vimium provides keyboard shortcuts for navigation and control in the spirit of Vim.", "icons": { "16": "icons/icon16.png", "48": "icons/icon48.png", -- cgit v1.2.3