From 4a00f76f2ad3d0ec8cdb70c7e45f561d5a73ff27 Mon Sep 17 00:00:00 2001 From: Stephen Blott Date: Wed, 31 Dec 2014 15:01:56 +0000 Subject: Fix vomnibar flicker after tabs mode. In tabs mode, the vomnibar is pre-populated when the query is empty. If, as part of hiding the vomnibar, we reset it, it becomes populated again, so the display style is reset from "none" to "block". Therefore, the completion list is briefly visible when the vomnibar is later reactivated. Solution: - Do not run `@update()` from `@reset()`. --- pages/vomnibar.coffee | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/vomnibar.coffee b/pages/vomnibar.coffee index 78c954cd..0ade7f0e 100644 --- a/pages/vomnibar.coffee +++ b/pages/vomnibar.coffee @@ -51,6 +51,7 @@ class VomnibarUI setCompleter: (completer) -> @completer = completer @reset() + @update(true) setRefreshInterval: (refreshInterval) -> @refreshInterval = refreshInterval @@ -66,7 +67,6 @@ class VomnibarUI @updateTimer = null @completions = [] @selection = @initialSelectionValue - @update(true) updateSelection: -> # We have taken the option to add some global state here (previousCompletionType) to tell if a search -- cgit v1.2.3