From a59875bbfd8182c64f3e1673ec1546b751e462b5 Mon Sep 17 00:00:00 2001 From: Julian Naydichev Date: Tue, 28 Dec 2010 20:13:53 -0800 Subject: Made is so that viewing source opens in the next tab, instead of replacing the current tab. --- background_page.html | 9 +++++++++ manifest.json | 2 +- vimiumFrontend.js | 2 +- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/background_page.html b/background_page.html index 264cf299..29dce3c7 100644 --- a/background_page.html +++ b/background_page.html @@ -70,6 +70,7 @@ var sendRequestHandlers = { getCompletionKeys: getCompletionKeys, getLinkHintCss: getLinkHintCss, + toggleViewSourceNewTab: toggleViewSourceNewTab, openUrlInCurrentTab: openUrlInCurrentTab, openOptionsPageInNewTab: openOptionsPageInNewTab, registerFrame: registerFrame, @@ -237,6 +238,14 @@ }); } + /** toggleViewSourceNewTab, opens source in new tab and switches to it + * + */ + function toggleViewSourceNewTab(request) { + chrome.tabs.getSelected(null, function(tab) { + chrome.tabs.create({ url: request.url, index: tab.index + 1, selected: true }); + }); + } /* * Returns the core CSS used for link hints, along with any user-provided overrides. */ diff --git a/manifest.json b/manifest.json index 0459a80b..ccac450a 100644 --- a/manifest.json +++ b/manifest.json @@ -1,6 +1,6 @@ { "name": "Vimium", - "version": "1.21", + "version": "1.22.1", "description": "The Hacker's Browser. Vimium provides keyboard shortcuts for navigation and control in the spirit of Vim.", "icons": { "16": "icons/icon16.png", "48": "icons/icon48.png", diff --git a/vimiumFrontend.js b/vimiumFrontend.js index a18c7966..c7701cab 100644 --- a/vimiumFrontend.js +++ b/vimiumFrontend.js @@ -304,7 +304,7 @@ function toggleViewSourceCallback(url) { url = url.substr(12, url.length - 12); } else { url = "view-source:" + url; } - chrome.extension.sendRequest({handler: "openUrlInCurrentTab", url:url}); + chrome.extension.sendRequest({handler: "toggleViewSourceNewTab", url:url}); } /** -- cgit v1.2.3 From 2c841be3e87e3fa14d9c4302c15854d2cb71fc5d Mon Sep 17 00:00:00 2001 From: Julian Naydichev Date: Wed, 29 Dec 2010 10:18:46 -0800 Subject: Changing function name, and parameters per Ilya's suggestion. --- background_page.html | 8 ++++---- manifest.json | 2 +- vimiumFrontend.js | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/background_page.html b/background_page.html index 29dce3c7..9f5c09a5 100644 --- a/background_page.html +++ b/background_page.html @@ -70,7 +70,7 @@ var sendRequestHandlers = { getCompletionKeys: getCompletionKeys, getLinkHintCss: getLinkHintCss, - toggleViewSourceNewTab: toggleViewSourceNewTab, + openUrlInNewTab: openUrlInNewTab, openUrlInCurrentTab: openUrlInCurrentTab, openOptionsPageInNewTab: openOptionsPageInNewTab, registerFrame: registerFrame, @@ -238,12 +238,12 @@ }); } - /** toggleViewSourceNewTab, opens source in new tab and switches to it + /** openUrlInNewTab, opens source in new tab and switches to it * */ - function toggleViewSourceNewTab(request) { + function openUrlInNewTab(request) { chrome.tabs.getSelected(null, function(tab) { - chrome.tabs.create({ url: request.url, index: tab.index + 1, selected: true }); + chrome.tabs.create({ url: request.url, index: tab.index + 1, selected: request.selected }); }); } /* diff --git a/manifest.json b/manifest.json index ccac450a..a1a135cd 100644 --- a/manifest.json +++ b/manifest.json @@ -1,6 +1,6 @@ { "name": "Vimium", - "version": "1.22.1", + "version": "1.22.2", "description": "The Hacker's Browser. Vimium provides keyboard shortcuts for navigation and control in the spirit of Vim.", "icons": { "16": "icons/icon16.png", "48": "icons/icon48.png", diff --git a/vimiumFrontend.js b/vimiumFrontend.js index c7701cab..32edf5aa 100644 --- a/vimiumFrontend.js +++ b/vimiumFrontend.js @@ -304,7 +304,7 @@ function toggleViewSourceCallback(url) { url = url.substr(12, url.length - 12); } else { url = "view-source:" + url; } - chrome.extension.sendRequest({handler: "toggleViewSourceNewTab", url:url}); + chrome.extension.sendRequest({handler: "openUrlInNewTab", url:url, selected: true}); } /** -- cgit v1.2.3 From 3a03c0f03ec447ae4e377b4a215ae100338d633d Mon Sep 17 00:00:00 2001 From: Julian Naydichev Date: Wed, 29 Dec 2010 10:22:28 -0800 Subject: Derp, forgot to change the version number, sorry --- manifest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manifest.json b/manifest.json index a1a135cd..161bdb30 100644 --- a/manifest.json +++ b/manifest.json @@ -1,6 +1,6 @@ { "name": "Vimium", - "version": "1.22.2", + "version": "1.22", "description": "The Hacker's Browser. Vimium provides keyboard shortcuts for navigation and control in the spirit of Vim.", "icons": { "16": "icons/icon16.png", "48": "icons/icon48.png", -- cgit v1.2.3 From 382f7bab504a1d44f832aa6abaa3603a23112da2 Mon Sep 17 00:00:00 2001 From: Ilya Sukhar Date: Thu, 30 Dec 2010 17:54:48 -0800 Subject: Added some docs for the latest pull request. --- CREDITS | 1 + README.markdown | 1 + 2 files changed, 2 insertions(+) diff --git a/CREDITS b/CREDITS index c1ccd981..d5f896b4 100644 --- a/CREDITS +++ b/CREDITS @@ -11,6 +11,7 @@ Contributors: drizzd int3 Johannes Emerich (github: knuton) + Julian Naydichev (github: naydichev) lack markstos rodimius diff --git a/README.markdown b/README.markdown index 04e7375d..3a9352ca 100644 --- a/README.markdown +++ b/README.markdown @@ -87,6 +87,7 @@ Release Notes 1.22 - Some sites are now excluded by default. +- View source (`gs`) now opens in a new tab. - Bugfixes. 1.21 (10/24/2010) -- cgit v1.2.3 From fdc320339e8cbdf978fe2259f247eec2e182a65f Mon Sep 17 00:00:00 2001 From: Ilya Sukhar Date: Thu, 30 Dec 2010 17:58:06 -0800 Subject: A little cleanup. --- background_page.html | 3 ++- vimiumFrontend.js | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/background_page.html b/background_page.html index 9f5c09a5..ac83a0c3 100644 --- a/background_page.html +++ b/background_page.html @@ -238,7 +238,8 @@ }); } - /** openUrlInNewTab, opens source in new tab and switches to it + /** + * Opens request.url in new tab and switches to it if request.selected is true. * */ function openUrlInNewTab(request) { diff --git a/vimiumFrontend.js b/vimiumFrontend.js index 32edf5aa..eb3de996 100644 --- a/vimiumFrontend.js +++ b/vimiumFrontend.js @@ -304,7 +304,7 @@ function toggleViewSourceCallback(url) { url = url.substr(12, url.length - 12); } else { url = "view-source:" + url; } - chrome.extension.sendRequest({handler: "openUrlInNewTab", url:url, selected: true}); + chrome.extension.sendRequest({handler: "openUrlInNewTab", url: url, selected: true}); } /** -- cgit v1.2.3