| Age | Commit message (Collapse) | Author |
|---|
|
The help-dialog UI component was ignoring requests to "hide" when other
frames are focused (because previously it covered the whole screen, and
no other frame could get the focus).
With f0911e52f0e71c6d2539bdc74a09ff2dbd5ab125, the help dialog no longer
covers the whole screen, so it must listen for and react to
"frameFocused" events.
However, the help dialog should not "hide" when the frame that is
focused is itself! This required a little extra plumbing. That
plumbing is helpful, though, because it allows individual UI components
to decide what to do when another frame receives the focus (as opposed
to the previious version, which simply unilaterally sent a "hide"
message).
|
|
Normally, we close the help dialog when the user clicks outside of it.
On the options page, however, the user might want the help dialog open
while they type command names into the key-mappings input.
Therefore, we disable hide-on-click for this specific use case.
This is a rather unfortunate hack. However, #2045 is a serious problem
for an important use case.
Fixes #2045.
|
|
|
|
We were using the class name exclusionRemoveButton for the `td`
containing the button to remove exclusion rules on the options page.
Because of this, we were (correctly) picking up the button itself as
clickable, but incorrectly picking up also its enclosing `td` (which
isn't actually clickable at all). The effect was to always have two
hint labels over the remove button.
This was happening simply because we have the text "button" in the class
name. So, here, we just rename the classes.
|
|
|
|
|
|
|
|
|
|
|
|
Make command names in the help diablog clickable.
|
|
|
|
The styles guide says not to use standalone `@`. So this changes the
occurrences I could find (with sed) to `this`. Occurrences within files
with major outstanding PRs are omitted.
|
|
Clicking on command names in the help dialog copies the command name to
the clipboard. Moreover, command names can be clicked (hence copied)
with link hints.
As a a side effect, any element on any page with the `vimiumClickable`
class becomes clickable. That's zero elements on zero pages, currently.
But there was a PR some time ago where a web developer was looking for a
way to make their elements vimium clickable.
On the negative side, this is pretty undiscoverable. Also, the
`indexOf()` class-name test within a string isn't exactly precise.
|
|
Add install date to logging page.
|
|
This is no longer necessary since the help page is in an iframe.
|
|
|
|
|
|
Oversight from #1958.
|
|
|
|
This implements a poor-man's build info.
See #1352. Unfortunately, that requires a separate build target, and
does not work with `cake autobuild`.
This just records the *install date* and displays that info on the
logging page. "Install date" because we can reliably determine it, and
because it does answer the question *have I upgrade Vimium on this
machine since last week?*. And on the logging page because that's out
of the way, and not part of the regular Vimium interface.
|
|
Moving to for own broke find mode history (and thus also next/previous).
This reverts that part of commit
56fed2ac6663d99ca03023f3ffa313c51de5fe32.
|
|
This makes the `hideHud` option apply only to insert mode (when entered with `i`).
Fixes #1953.
Fixes #487.
We could rename the option itself and add migration code, but that seems overkill.
An alternative would be to remove this option entirely.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This prevents issues like #1731 and is an (better) alternative to #1732.
|
|
|
|
|
|
|
|
... for FindModeHistory.
|
|
|
|
|
|
|
|
|
|
|
|
This keeps searches with trailing spaces from missing matches where the
page contains normal spaces, preventing " (No matches)" being shown
every time space is pressed.
|
