| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
|
|
|
|
|
|
This implements a generic front-end class for key handling (a la normal
mode). Also:
- supports count prefixes (or not)
- supports multi-key mappings (longer than two)
Also included is a very poor-man's demo. See the bottom of
mode_key_handler.coffee for some hard-wired key bindings.
IMPORTANT:
This does not actually work as Vimium. It's just a demo.
|
|
The options page receives messages intended for the background page (and
we're getting console warnings). This is a more general test for when
the front end should ignore such messages.
Fixes #2034.
|
|
A small refactor link hints.
|
|
- The check for whether a rect is defined is only used in one of the
three cases. So we don't need it.
- Also, better veriable name.
|
|
The styles guide says not to use standalone `@`. So this changes the
occurrences I could find (with sed) to `this`. Occurrences within files
with major outstanding PRs are omitted.
|
|
|
|
Previously, we set a variable `delay` and then did some logical
gymnastics to get the correct effect.
However, in fact, all we care about is whether the user might over-type
the links text. So changing to using that as a Boolean flag greatly
simplifies the logic. And we lose about 10 LoC.
|
|
While we're changing this code, we can renamed the parameter here to be
consistent with its naming elsewhere.
|
|
Somehow,
|
|
Previously (quite some time ago) we reused the LinkHints object. But
for some time it's been a class, and we never reuse instances.
Therefore, we can remove the code related to resetting the object's
state.
|
|
Previously, the exit sequence when a link was "clicked" was spread over
several functions with several callbacks. This made it difficult to
verify that the correct actions were happening in the correct order.
Indeed, they weren't in at least one case (we were still showing hints
while "waiting for enter").
This fixes that by putting all of the various deactivation orders into
one place, `@activateLink()`, and simplifies `@deactivateMode()`
accordingle.
|
|
|
|
We were immediately restarting link-hints mode if a count was present.
Unfortunately, that meant that we were detecting our own link-hint click
and exiting immediately. So, with a count of 6, we were only getting 3
link-hint activations.
To avoid this, we add a short delay (just nextTick).
Also, move some other stuff arund to make sure this works in all cases
(e.g. wait-for-enter).
|
|
Refactor focusFrame - Fix #2023.
|
|
Only the `flashFrame` part needs to be guarded against the DOM being
ready. So we can take the `flashFrame` part out as a regular function.
Fixes #2023 (although I don't fully understand why that's happening).
|
|
Currently, `10j` keeping `j` held down scrolls quickly for a time then
reduces back the regular hold-`j` scroll speed. Therefore, the user
cannot use a count to influence the smooth-scrolling scroll speed.
This PR fixes that by passing the count to the scroll functions.
Consequently, we adjust the actual scroll amount (which affects the
scroll speed) rather than calling the scroll commands several times
(which doesn't).
|
|
|
|
Omitted from #1961.
|
|
If text.length is 1, here, then we divide by `log 1` - which is zero.
So add one.
|
|
It appears `tabInfoMap` (and related machinery) is not being used. This
removes it.
|
|
When we introduced command options (for mapping keys to custom-search
engines), the parsing was done in the Vomnibar code.
This moves the parsing to `commands.coffee`, which is where it should
always have been.
This is a preliminary step with a view to adding a new `count` command
option.
|
|
This makes the `hideHud` option apply only to insert mode (when entered with `i`).
Fixes #1953.
Fixes #487.
We could rename the option itself and add migration code, but that seems overkill.
An alternative would be to remove this option entirely.
|
|
|
|
This affects filtered hints only.
If a hint is triggered because the user typed the link text, then:
- highlight the link
- but wait until the user types `Enter` before activating the link.
|
|
Oversight from 116ac2c2a279f8497ffd5396f43ac4fd7fd5de67.
|
|
This allows:
map a passNextKey
map b passNextKey
(Previously, we only picked up the first mapping.)
|
|
(First "fully" functional version.)
|
|
Previously, key event parsing was embedded in the normal-mode key
handlers. Here, we move it to a new function (getKeyCharString) in
KeyboardUtils so that it can also be used from elsewhere... In
particular for detecting the pass-next-key key in insertmode.
|
|
This implements a passNextKey command (initially for normal mode only),
as discussed in #1955.
|
|
|
|
This affects the scoring system for filtered link hits, and therefore
affects their usability.
Example link text:
"We open all day", say 7Eleven
Previously:
"We
open
all
day",
say
7Eleven
With this PR:
we
open
all
day
say
Eleven
Previously: the typed text `we` and `day` would receive poor scores (not
the start of a word, and not a whole word. Now, these get high scores,
so are more likely to be selected as the active link. Also, `7Eleven`
cannot be typed (because `7` is a hint character).
With this PR, the typed text `we` `day` now get high scores, as they
should.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
