| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
This logic should never have been in settings.coffee. This moves it to completion.coffee, where it belongs.
|
|
|
|
We're asking for the "notifications" permission. I'm not sure what
happens. If the user is asked to accept the permission, then we
wouldn't show the notification until the next time Vimium starts.
Instead, we check more frequently. So the notification will show the
next time a tab is created (or changes page).
|
|
|
|
Conflicts:
content_scripts/vimium_frontend.coffee
|
|
|
|
|
|
"pages/blank.html" was being sent to the default search engine by
chrome.tabs.create().
Not fully functional. New tabs created from incognito mode are created
in a non-incognito mode window.
|
|
Setting the page icon is now driven from the corrently-active frame.
- Eliminates a race condition.
- Icon matches actual frame state (not tab URL state).
- Exclusion-rule changes propagate to all frames.
|
|
When the active tab changes, we call updateActiveState to update the
icon and propagate any changed exclusion-rule state to the tab. All
frames received the request. However, only one response is received by
the background page. Therefore, new exclusion rules are only propagated
to one frame.
Here's what can go wrong...
On gmail, open the hangouts frame. Add an exclusion rule sepcific to
the hangouts frame. Save it. The update is propagated only to the main
frame. The new exclusion rule is not in effect in the hangouts frame.
That's wierd and obviously wrong.
In this commit, every frame receiving the getActiveState request also
calls checkIfEnabledForUrl to ensure that any new exclusion-rule state
is propagated. This is overkill, to some extent. We should really move
settings to chrome.storage and have each frame check locally for changes
affecting it.
|
|
Previously, we have been populating the suggested exclusion URL in the
page popup with the tab's URL. This uses the active frame's URL
instead:
- because this is the URL which will affect the current frame (without
this, a user can naively add an exclusion rule and it has no effect),
and
- because, without this, the user has no reasonable way to add exclusion
rules for frames such as the hangouts frame on gmail (for which, the
URL is not displayed in the address bar).
|
|
We should not inject content scripts on chrome upgrades.
|
|
|
|
This is @mrmr1993's work from #1041.
Reload content scripts when vimium is installed or updates.
(@mrmr1993: The automatic merge was really messy (or, at least, I
couldn't figure out what was going on). Since the bulk of #1041 was
actually quite compact, I took the liberty of just copying it in. Hope
you don't mind.)
|
|
This is a quick fix only (to keep master in a functional state).
openUrlInNewTab is broken, and needs to be refactored.
|
|
|
|
|
|
|
|
- This fix enables `2t` to open two new tabs, even in incognito.
Include callback in the call chain so that numbered commands can work.
|
|
Following on from c8d984520f5de4b3e702cee992c7ecc4f4f49435, I forgot to
fix up the other call to setBadge.
|
|
Fixes #1491.
|
|
- Change openUrlInNewTab to pass tab.windowId
Why? Work around for upstream bug #308171
- Change createTab to use openUrlInNewTab
Why? Fix issue #1507 to open new tab in current window
(Note: This commit removes noise from the code and explains the changes)
|
|
- Change openUrlInNewTab to pass selected tab.windowId
- Change createTab to use openUrlInNewTab
|
|
smblott-github/fix-incognito-and-find-history-initialisation
Ensure incognito-mode flag and find-mode-history are initialised.
|
|
See #1495.
|
|
|
|
And, following on from 7a746ba51a5124a39acb09270bf4ab470bfd6b5f:
- 7a746ba51a5124a39acb09270bf4ab470bfd6b5f seems to work. However,
there's a slight unnecessary flicker when changing tab. So, this
tries *not* setting an initial icon, and waiting instead to hear
back from the tab.
|
|
Following on from 6d776a9f56f05e4298577f25f0a54b924cb1f6e6, I'm still
seeing issues with the browser icon showing disabled which Vimium is in
fact enabled.
I'm going to try this for a bit, and see if it fixes the problem.
|
|
|
|
Doh! I didn't know this existed.
|
|
Retain frame data for a tab unless the top frame tells us its closing
|
|
I'm seeing an intermitent issue whereby the browser icon is showing as
disabled, when vimium is in fact enabled. It's intermitent, so
difficult to track down.
I went back to look at the old code for setting the browser icon, and
reset this code to look more like the old code. I suspect the problem
may be that we disabling the icon because we're getting no response from
one frame (or something like that).
|
|
It seems this was probably used at some point before the introduction of
settings.set() in the front end. It isn't used at all, now.
|
|
- Fix incorrect camel case in option name.
- Better text on options page.
- Loud comments re. using option directly from chrome.storage.sync.
|
|
- add new option "GrabBackFocus"
- use chrome.storage.sync.get() to get option value
- avoid race conditions on load
- fix tests
|
|
|
|
|
|
Fix conflicts from 9f20c33adf75e2e78b35e2cd16f2a0925a72c577.
|
|
Conflicts:
background_scripts/main.coffee
|
|
This is wrong:
if not key of Settings.defaults
It parses as:
if (not key) of Settings.defaults
and is always false, so we never return here!
|
|
Conflicts:
background_scripts/main.coffee
content_scripts/vimium_frontend.coffee
lib/keyboard_utils.coffee
|
|
|
|
This fixes a second dumb error I made in #1456.
|
|
|
|
|
|
Approach:
- We never save the find mode history from an incognito tab in the
settings, instead they are saved in the tabMapInfo for each
currently-active incognito tab.
- When a new incognito tab (or page, after navigation) starts, we
scan the tabMapInfo looking for the find-mode history of any active
tab.
In this way, the history is shared between incognito tabs, but discarded
once the last incognito tab closes.
|
|
|
|
|
