aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2017-04-22Firefox: Polyfill for selection.type for visual mode.Stephen Blott
@mrmr1993... This puts the logic of how we choose the selection type in one place; so, if you have a better idea of how to determine the selection type, then we just change it here. Once.
2017-04-22Refactor getSelectionType() to DOM utils.Stephen Blott
This is a no-op. It is preparatory to implementing a suitable polyfill for `selection.type` for Firefox.
2017-04-22Revert "Firefox: Fix visual mode."Stephen Blott
This reverts commit 50b117733c4f0ecf9fd507c28d2f2967b5b1404b. Reverting this. In response to comments from @mrmr1993, this is not the best way of achieving what's required.
2017-04-21Firefox: Fix waitForEnterForFilteredHints.Stephen Blott
This is the filtered-hints feature whereby links aren't activiated until the user hits `Enter`. There was a race condition caused by forcing this setting to true for new users *before* the correct storage area was determined in `Settings.init()`. Mention @mrmr1993.
2017-04-21Firefox: Fix visual mode.Stephen Blott
The problem with visual mode is that `@selection.type` isn't implemented in Firefox/Gecko. Here, we simulate the same effect with `anchorNode` and the length of the selection. Mention @mrmr1993.
2017-04-21Firefox: Fix createTab.Stephen Blott
Firefox baulks at "about:newtab" in createTab (but seems happy with no URL specified). Chrome is also happy with no URL specified. (Does this mean that we don't need "about:newtab" ANYWHERE in the code base? Could Settings.defaults.newTabUrl just be ""?) Mention @mrmr1993.
2017-04-21Fix tab for link-hint selection.Stephen Blott
We were leaking the keydown event to the page when using TAB to select link hints (filtered hints).
2017-04-21Firefox: Fix format of popup buttons.Stephen Blott
@mrmr1993: This is trivial fix for Firefox, so it doesn't warrant a PR. I'll mention you just to keep you up to date on commits like this, though.
2017-04-21Merge pull request #2484 from mrmr1993/ff-focus-top-frameStephen Blott
Fix gF (mainFrame) command on Firefox
2017-04-20Blur the focused iframe when restoring window focusmrmr1993
This works around FF issue 554039, which prevents window.top.focus() from working.
2017-04-20Merge pull request #2482 from smblott-github/firefox-history-no-titleStephen Blott
Firefox: some history entries have no title.
2017-04-20Firefox: some history entries have no title.Stephen Blott
This causes `o`/`O` to crash (producing no suggestions). As a workaround, set any such title to "".
2017-04-19Simplify isPrintable(event) test.Stephen Blott
2017-04-18Note Firefox and key handling in README.md.Stephen Blott
2017-04-18Merge pull request #2470 from smblott-github/rework-key-handling-to-keydownStephen Blott
Rework key handling to keydown
2017-04-18Better check for handlerId.Stephen Blott
2017-04-18Set handlerId directly to a non-id.Stephen Blott
2017-04-18Fix <Shift> or <Ctrl> link-hint behaviour.Stephen Blott
Error was introduced by seemingly innocuous but nevertheless significant change in previous commit. Tests picked up the problem.
2017-04-18Make the consumeKeyup handler a singleton.Stephen Blott
That is, allow at most one handler to be installed at any one time. I have not observed this to be necessary. However, if there were any systematic way in which we weren't seeing the necessary keyup events, then these handlers would just be added and added. So this seems safer.
2017-04-18Fix filtered link hints.Stephen Blott
For filtered link hints, " " was broken; it was treated as "space".
2017-04-18Use event.code to detect/suppress keyup events.Stephen Blott
This avoids the possibility of leaking keyup events if the keys a released in a different order from that in which they were pressed. Also, replace suppressKeyupAfterEscape with this same mechanism. This fixes a bug (in master/1.59) whereby we leak the keyup event for `i` when entering insert mode. TODO: - `/`, `<Escape>` leaks a keyup event - `i` leaks a keyup event
2017-04-18Continue bubbling unmapped events.Stephen Blott
2017-04-18Do not reset key state for modifiers.Stephen Blott
2017-04-18Avoid repeating Backspace and Delete keys.Stephen Blott
2017-04-18Ignore keybiard repeats.Stephen Blott
Keyboard repeats were interfering with smooth scrolling. But we should be ignoreing them anyway.
2017-04-18Remove use of keyCodes entirely.Stephen Blott
event.keyCode` is depricated: - https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode
2017-04-18Rework tests for all key handling on keydown.Stephen Blott
2017-04-18Remove out-of-date comment.Stephen Blott
2017-04-18Migrate marks to keydown only.Stephen Blott
2017-04-18Migrate link hints to keydown only.Stephen Blott
2017-04-18Move keyboard utils to keydown and migrate normal/visual modes.Stephen Blott
2017-04-18Merge pull request #2476 from mrmr1993/firefoxStephen Blott
Improve firefox support
2017-04-18Merge pull request #2478 from mrmr1993/always-update-helpStephen Blott
Regenerate help page data when key bindings are updated
2017-04-18Check whether chrome.storage.sync is enabled, fall back to .local if notmrmr1993
2017-04-17Regenerate help page data when key bindings are updatedmrmr1993
2017-04-17Remove content_script_loader and all references to itmrmr1993
2017-04-17Clarify postFindFocus and obviously separate it from the try..catchmrmr1993
2017-04-16Use browser independent new tab page URL (about:newtab)mrmr1993
2017-04-16Rework FindMode HUD refocusing to not depend directly on the HUDmrmr1993
2017-04-16Catch errors thrown by window.find when it wraps/fails on FFmrmr1993
This does NOT fix wrapping, only catches errors
2017-04-16Guard against unsupported non-standard contentEditable=plaintext-onlymrmr1993
2017-04-16Only remove settings from storage.local if it's not our main storemrmr1993
2017-04-16Add a comment to manifest about content scripts in pages/*.htmlmrmr1993
2017-04-16Revert "Use HTML5 import to load content scripts."mrmr1993
This reverts commit d00345f45b5b3e56970237799c69808527e91919. This is not (and will not be) supported by Firefox.
2017-04-16Workaround type error for unsupported openerTabId in FFmrmr1993
2017-04-16Fallback to storage.local if storage.sync is not availablemrmr1993
2017-04-13Merge pull request #2471 from mrmr1993/ff-options-textbox-wrapStephen Blott
Show line breaks for newlines in the options page (FF)
2017-04-13Use white-space: pre; for options page inputsmrmr1993
For textareas, we still want line breaks, otherwise we would use an input. Chrome (incorrectly) renders newlines in `white-space: nowrap` as line breaks; however, firefox collapses the newlines into horizontal whitespace. `white-space: pre` is spec'd as intended, and works correctly in Chrome and FF.
2017-04-13Merge pull request #2460 from novelview9/patch-1Stephen Blott
fix typo
2017-04-07Bump version to 1.59.v1.59Stephen Blott