aboutsummaryrefslogtreecommitdiffstats
AgeCommit message (Collapse)Author
2015-06-22Merge pull request #1747 from gdh1995/masterStephen Blott
fix a bug that `pasteFromClipboard` does not return text from clipboard
2015-06-22fix a bug that `pasteFromClipboard` does not return text from clipboardgdh1995
2015-06-20TweaksDaniel Skogly
In regards to https://github.com/philc/vimium/commit/9475c51932fc3331e515886b0495c5b86a1a9e65
2015-06-20The second part of b09822eb349ec88a573d4f450e9b57e8fa3c6473 is incorrect.Stephen Blott
Revert it.
2015-06-20Fix SimpleCache bugs.Stephen Blott
This fixes two bugs in SimpleCache. 1. Rotate the cache on the next tick. There is a marginally small chance that the cache will rotate between calls to .has() and .get(). So, we do the rotation ansynchronously. This guarantees that these two functions will always see the same cache state. 2. The implementation of .clear() (which is unused, I think) has at some point become out of date (and incorrect) w.r.t. the implementation of .rotate().
2015-06-20Adding debugging infrastructure for settings.Stephen Blott
2015-06-20Document options/settings data model.Stephen Blott
2015-06-20Document options/settings data model.Stephen Blott
2015-06-20Add test that every option has a default value.Stephen Blott
This prevents issues like #1731 and is an (better) alternative to #1732.
2015-06-20Merge pull request #1736 from ↵Stephen Blott
smblott-github/remember-show-advanced-options-state Make "Show Advanced Options" state persistent.
2015-06-19More concise commentDaniel Skogly
Because I apparently can't read docs properly!
2015-06-19Clarifications to ngClick checkDaniel Skogly
2015-06-18Proper function callDaniel Skogly
CoffeeScript is not my native tongue.
2015-06-18Proper function definitionDaniel Skogly
Changed from : to =
2015-06-18Added hasNgClick-check in getVisibleClickableDaniel Skogly
There's a fair amount of angular-sites running around, so including ngClick (with all its valid variations) seems like a good idea. I added a hasNgClick-check in the if block that checks if an element is clickable regardless of tagName.
2015-06-17Merge pull request #1740 from smblott-github/synchronise-initialisationStephen Blott
Initialise modes and install listeners at the same time.
2015-06-17Reinstate unintentionally deleted code.Stephen Blott
2015-06-17Initialise modes and install listeners at the same time.Stephen Blott
Previously, we initialised modes early, but then installed our listeners only after DOM ready, and then only after we'd heard back from the background page in `checkIfEnabledForUrl`. This creates a gap during which modes are installed, but they're not receiving events. If an input is focused during that gap, then we don't pick it up when the modes are installed, and we don't pick it up when the input is focussed (because we're not listening). This commit moves these two initialisation steps together, so they happen at the same time and there is no gap. Fixes #1738.
2015-06-17Fix non-default front-end settings.Stephen Blott
(@mrmr1993: This is yet another approach to the Settings problem.) With the new Settings implemetation, settings which have a non-default value and which are not in synced storage (that is, they have not been changed since synced storage was introduced) are not currently accessible to content scripts. This commit makes such settings accessible via chrome.storage.local. Important: - There's a change to the established settings data model here. Previously, settings with default values were not stored; here, they are. This eliminates a considerable amount logic from Settings, but means that migrations will be required if default values are changed in future. (Other than type changes, have we ever changed a default value?) - There's also a change (bug fix?) to the behaviour when an affected setting is reset to its default value. Previously, the change would *not* have been synced (whereas all other changes are). Here, such changes *are* synced. The previous behaviour was inconsistent with the syncing behaviour of all other options changes. Note: - This isn't particularly well tested. It's being committed mainly just for consideration of the approach, initially.
2015-06-16Make "Show Advanced Options" state persistent.Stephen Blott
2015-06-14Add default value for regexFindMode setting.Stephen Blott
Because we haven't had a default value for this setting, we never sync it, which means -- when its not at its default value -- it isn't picked up in content scripts by the new settings system. Fixes #1731.
2015-06-13Pad the HUD leading / with a "hair space"mrmr1993
2015-06-13Clean up code after mergemrmr1993
2015-06-13Merge pull request #1 from smblott-github/hud-iframe-inputMatthew Ryan
Hud iframe input
2015-06-13Suppress arrow events in find-mode HUD.Stephen Blott
2015-06-13Place cursor at end of find-mode input...Stephen Blott
... for FindModeHistory.
2015-06-13Refactor duplicate code.Stephen Blott
2015-06-13Fix returnToViewport.Stephen Blott
The super-class's constructor sets @options, so we can't set it here; instead, we pass the options along.
2015-06-13Refactor findInPlace.Stephen Blott
This code belongs together, so we put it together.
2015-06-11Make exiting FindMode with <esc> work as it should againmrmr1993
This undoes the effect of the breaking refactor in 73f66f25e6b8e5b5b8456074ad4fa79ba1d3ca4d, where PostFindMode was entered whenever FindMode was exited, instead of only when it was exited with <enter>.
2015-06-11Merge pull request #1726 from smblott-github/rank-filter-hintsStephen Blott
Rank filtered hints by score.
2015-06-11Revert "Make "a-z" characters work in filter hints mode."Stephen Blott
This reverts commit 53d131700e5f33cb9476f00a905c238b0083f3dc. (This needs more thought.)
2015-06-11Make "a-z" characters work in filter hints mode.Stephen Blott
When we read hint characters, we read them lower case. When we generate hint markers, we generate them upper case. So they never match. (Exactly why anyone would want to use "abcde" for filtered link hints isn't clear, but at least we should behave correctly.)
2015-06-11Initialise options-page link-hint mode correctly (better).Stephen Blott
2015-06-10Update rawQuery directly from FindMode.updateQuerymrmr1993
2015-06-10Integrate executeFind into FindMode as FindMode.executemrmr1993
2015-06-10Move findModeQuery to FindMode.querymrmr1993
2015-06-10Make find from visual mode behave the same as a normal findmrmr1993
2015-06-10Coffee-ify strings, fix no match regexp search message in visual modemrmr1993
2015-06-10Simplify executeFind by hardcoding default argumentsmrmr1993
2015-06-10Add FindMode.saveQuery to avoid addressing findModeQuery directlymrmr1993
2015-06-10Remove redundant conditionalmrmr1993
2015-06-10Integrate functions exposed on window into FindModemrmr1993
2015-06-10Move getNextQueryFromFindModeMatches and getFindModeQuery into mode_findmrmr1993
2015-06-10Move updateFindModeQuery to FindMode.updateQuerymrmr1993
2015-06-10Move updateFindModeQuery to mode_find.coffeemrmr1993
2015-06-10Inline HUD.findModeKeydown at its sole callsitemrmr1993
2015-06-10Remove redundancy in HUD.findModeKeydownmrmr1993
2015-06-10Initialise options-page link-hint mode correctly.Stephen Blott
2015-06-10Merge pull request #1728 from smblott-github/fix-tab-moveStephen Blott
Fix tab move.