| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Set the parent tab when creating tabs.
|
|
(We need to use "this" inside this function.)
|
|
(We need to use "this" inside this function.)
|
|
This makes global marks use the same code for opening new tabs as other
operations. Thus, the new tab appears in the same position as it would
if it were created, for example, via the vomnibar.
To do this properly, we move the three tab-creating functions into an
object which can be (and is) exported (TabOperations).
Also fixes these three operations such that they all take the same
arguments; that is (request, callback). Not all of these callbacks are
being used. But we should be consistent.
|
|
If the tab is subsequently deleted, then we return to the original tab
(as opposed to the one on its right).
|
|
|
|
|
|
This only affects the transition from visual mode back to edit mode.
Previously, we were incorrectly leaving the selection in place.
(The comment above was correct, but the implementation wasn't.)
|
|
fix a bug that `pasteFromClipboard` does not return text from clipboard
|
|
|
|
Revert it.
|
|
This fixes two bugs in SimpleCache.
1. Rotate the cache on the next tick. There is a marginally small
chance that the cache will rotate between calls to .has() and .get().
So, we do the rotation ansynchronously. This guarantees that these
two functions will always see the same cache state.
2. The implementation of .clear() (which is unused, I think) has at some
point become out of date (and incorrect) w.r.t. the implementation of
.rotate().
|
|
|
|
|
|
|
|
This prevents issues like #1731 and is an (better) alternative to #1732.
|
|
smblott-github/remember-show-advanced-options-state
Make "Show Advanced Options" state persistent.
|
|
Initialise modes and install listeners at the same time.
|
|
|
|
Previously, we initialised modes early, but then installed our listeners
only after DOM ready, and then only after we'd heard back from the
background page in `checkIfEnabledForUrl`. This creates a gap during
which modes are installed, but they're not receiving events.
If an input is focused during that gap, then we don't pick it up when
the modes are installed, and we don't pick it up when the input is
focussed (because we're not listening). This commit moves these two
initialisation steps together, so they happen at the same time and there
is no gap.
Fixes #1738.
|
|
(@mrmr1993: This is yet another approach to the Settings problem.)
With the new Settings implemetation, settings which have a non-default
value and which are not in synced storage (that is, they have not been
changed since synced storage was introduced) are not currently
accessible to content scripts. This commit makes such settings
accessible via chrome.storage.local.
Important:
- There's a change to the established settings data model here.
Previously, settings with default values were not stored; here, they
are. This eliminates a considerable amount logic from Settings, but
means that migrations will be required if default values are changed
in future. (Other than type changes, have we ever changed a default
value?)
- There's also a change (bug fix?) to the behaviour when an affected
setting is reset to its default value. Previously, the change would
*not* have been synced (whereas all other changes are). Here, such
changes *are* synced. The previous behaviour was inconsistent with
the syncing behaviour of all other options changes.
Note:
- This isn't particularly well tested. It's being committed mainly just
for consideration of the approach, initially.
|
|
|
|
Because we haven't had a default value for this setting, we never sync
it, which means -- when its not at its default value -- it isn't picked
up in content scripts by the new settings system.
Fixes #1731.
|
|
|
|
|
|
Hud iframe input
|
|
|
|
... for FindModeHistory.
|
|
|
|
The super-class's constructor sets @options, so we can't set it here;
instead, we pass the options along.
|
|
This code belongs together, so we put it together.
|
|
This undoes the effect of the breaking refactor in
73f66f25e6b8e5b5b8456074ad4fa79ba1d3ca4d, where PostFindMode was entered
whenever FindMode was exited, instead of only when it was exited with
<enter>.
|
|
Rank filtered hints by score.
|
|
This reverts commit 53d131700e5f33cb9476f00a905c238b0083f3dc.
(This needs more thought.)
|
|
When we read hint characters, we read them lower case. When we generate
hint markers, we generate them upper case. So they never match.
(Exactly why anyone would want to use "abcde" for filtered link hints
isn't clear, but at least we should behave correctly.)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
