| Age | Commit message (Collapse) | Author |
|---|
|
|
|
This delivers a "hidden" massage to the vomnibar after the vomnibar has
been hiddent in the host page. The vomnibar only performs whatever
action is required when it receives this "hidden" message.
|
|
Fix oversight from #1517.
|
|
This is not entirely satisfactory. It would be great if a delay of 0
worked (a la `nextTick`). But it seems we need a little longer because
we need to allow the UI component messaging to complete.
An alternative would be to thread the action required through the UI
component logic. But that's pretty ugly too.
Yet another alternative would be to have the UI Component post an "ok,
we're done, do it" message once the UI component has been removed.
Fixes #1485.
|
|
|
|
|
|
Mainly fix the indentation on comments. Also tweak wording a bid.
|
|
Click:
- in the vomnibar focuses the input
- anywhere else (such as in the space below the vomnibar) hides the
vomnibar.
This makes clicks in the space below the vomnibar behave the same as
clicks in the page itself... Which makes sense, because the difference
is not apparent to the user.
|
|
Fixes #1506.
This takes the opposite approach to #1511. Instead of hiding the
vomnibar when it blurs, we hide it when it's host frame is focused.
|
|
This is a quick fix only (to keep master in a functional state).
openUrlInNewTab is broken, and needs to be refactored.
|
|
|
|
|
|
|
|
|
|
|
|
This only effects link hints with "Use the link's name and numbers for
link-hint filtering" enabled.
We have been matching the *entire text content* of each link-hint
element.
With two (or more) hints, and with one of the elements a descendent of
the other, we have been using the entire text content of the outer node
(which includes the text content of the inner node). This leads to odd
situations where the inner element cannot be selected just by typing its
text, because its text is a substring of the outer element's text.
For example, on Google calendar, the "Today" button shows up as two
hints, one inside the other. Typing "today" never disambiguates the
hint. You always have to hit enter.
There's another nasty example on feedly, where an outer container is
clickable, but its text contains all of the (many) texts of the (many)
contained links. So the hint always has to be selected manually.
Here, when generating the text for an element, we exclude the texts from
any descendent node which has already been considered.
|
|
- This fix enables `2t` to open two new tabs, even in incognito.
Include callback in the call chain so that numbered commands can work.
|
|
This adds another handler which is delivered to the options page, but
for which there is no handler. This was causing an exception on the
background page (console).
|
|
Following on from c8d984520f5de4b3e702cee992c7ecc4f4f49435, I forgot to
fix up the other call to setBadge.
|
|
Fixes #1491.
|
|
- Change openUrlInNewTab to pass tab.windowId
Why? Work around for upstream bug #308171
- Change createTab to use openUrlInNewTab
Why? Fix issue #1507 to open new tab in current window
(Note: This commit removes noise from the code and explains the changes)
|
|
- Change openUrlInNewTab to pass selected tab.windowId
- Change createTab to use openUrlInNewTab
|
|
The intention here is that, under visual mode, a find query with no
matches leaves us at some aribtrary place in the page. Whereas the user
was probably looking at the text they're interested in in the viewport
to begin with. This PR returns to the original viewport in such cases.
(In this commit, return-to-viewport is enabled for *all* finds, not just
under visual mode. I want to try it out like this to see what it feels
like. This is probably not the right UX. It is not what Chrome does.)
|
|
smblott-github/fix-incognito-and-find-history-initialisation
Ensure incognito-mode flag and find-mode-history are initialised.
|
|
.. and don't forget to actually use the incognitomode flag in the front
end.
|
|
See #1495.
|
|
|
|
This restores behaviour to how it was at commit
7cedc5d2481f61f4b0d1cbf99fbd203bb5c68b54.
|
|
|
|
|
|
|
|
|
|
These elements throw an error on access, meaning that we can't do an
existence check.
|
|
And, following on from 7a746ba51a5124a39acb09270bf4ab470bfd6b5f:
- 7a746ba51a5124a39acb09270bf4ab470bfd6b5f seems to work. However,
there's a slight unnecessary flicker when changing tab. So, this
tries *not* setting an initial icon, and waiting instead to hear
back from the tab.
|
|
Following on from 6d776a9f56f05e4298577f25f0a54b924cb1f6e6, I'm still
seeing issues with the browser icon showing disabled which Vimium is in
fact enabled.
I'm going to try this for a bit, and see if it fixes the problem.
|
|
Rationale. There are really two insert modes: the one we activate with
"i" and the one that's activated when a focusable element receives the
focus. This makes that distinction clearer. And, in particular, it
means that, when the latter type of insert mode is active, we *know*
that gloabl insert mode is *not* active.
|
|
Updated README.md readability -- missed two lines
|
|
Missed two lines from my original pull request (https://github.com/philc/vimium/pull/1481). Basically:
Changed references to vimiim commands that were either in single-quotes or not otherwise distinguished easily to the reader as a command to be wrapped around backtick quotes so they will stand out. Here is a list of all changes made:
Line 215, 'b' updated to `b`
Line 240, 'g0' updated to `g0` and 'g$' updated to `g$`
|
|
Added Markup code tags to commands in Readme.md
|
|
Changed references to vimiim commands that were either in single-quotes or not otherwise distinguished easily to the reader as a command to be wrapped around backtick quotes so they will stand out. Here is a list of all changes made:
Line 92, the reference to ‘5t’ used to be in single quotes, is now `5t`.
Line 174, updated gU to `gU`.
Line 175, updated yt to `yt`.
Line 176, updated W to `W`.
Line 177, updated mX to `mX` and `X to `X`.
Line 228, updated “o” to `o`
Line 240, updated g0 to `g0` and g$ to `g$`
Line 241, updated p/P to `p`/`P`
Line 249, updated Tab to `Tab` and shift-tab to `shift-tab`.
Line 318, updated ‘u’ to `u`.
Line 320, updated ‘unmapAll’ to `unmapAll`.
Line 327, updated “?” to `?`.
Line 335, updated Ctrl+D to `Ctrl+D` and Ctrl+U to `Ctrl+U`.
Line 346, updated J to `J` and K to `K`.
Line 353, updated ‘gt’ to `gt` and ‘gT’ to `gT`.
Line 354, updated ‘yy’ to `yy`.
Line 356, updated Shift+F to `Shift+F`.
Line 357, updated ESC to `ESC` and ‘g’ to `g`.
No other changes have been made to this file, this update is intended to strictly improve readability.
|
|
|
|
Doh! I didn't know this existed.
|
|
Retain frame data for a tab unless the top frame tells us its closing
|
|
I'm seeing an intermitent issue whereby the browser icon is showing as
disabled, when vimium is in fact enabled. It's intermitent, so
difficult to track down.
I went back to look at the old code for setting the browser icon, and
reset this code to look more like the old code. I suspect the problem
may be that we disabling the icon because we're getting no response from
one frame (or something like that).
|
|
The lack of a callback here was causing errors when loading (at least)
the options page.
|
|
It seems this was probably used at some point before the introduction of
settings.set() in the front end. It isn't used at all, now.
|
|
- Fix incorrect camel case in option name.
- Better text on options page.
- Loud comments re. using option directly from chrome.storage.sync.
|
|
Fix performFind/performBackwardsFind for regexp searches
|
|
|
|
- add new option "GrabBackFocus"
- use chrome.storage.sync.get() to get option value
- avoid race conditions on load
- fix tests
|
