| Age | Commit message (Collapse) | Author |
|---|
|
Since the vomnibar now always is initialised and opened the top window
(see d67347461da5a0468547e4c807a54bb40746faf4), there's no longer a need
for this to be a Vimium Labs feature.
|
|
Vomnibar commands are handled in a frame even is isEnabledForUrl is
false.
|
|
|
|
|
|
|
|
Clean up, and fixes following code review from @mrmr1993.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This changes vomnibar commands to activate not in the current frame, but
in window.top. Consequently, the vomnibar always appears in the same
position, and we don't get odd looking vomnibars in small frames.
Apart from the better UX, this seems to be the right thing to do.
Vomnibar commands apply to tabs (not frames).
Currently incomplete:
- On exit, the focus is not returned to the frame which originally
had the focus. (It's returned to window.top).
- The vomnibar can lose the focus and not hide itself for various
frame/click combinations.
|
|
|
|
|
|
"pages/blank.html" was being sent to the default search engine by
chrome.tabs.create().
Not fully functional. New tabs created from incognito mode are created
in a non-incognito mode window.
|
|
In b05276ed8264e5a71f20a7068690ba2a414ee6d8, I inadvertently moved the
focus handler from window to document. As a consequence, detectFocus
(now registerFocus) wasn't being called when expected.
|
|
Move Scroller.init() up the handler stack.
|
|
Move scroller initialisation so that its key handlers are above insert
mode in the handler stack. This ensures that the scroller sees keyup
events if we enter insert mode while continuous scrolling.
Fixes #1526.
|
|
We should not inject content scripts on chrome upgrades.
|
|
The page (or another extension) sees keydown events (such as shift)
before entering link-hint mode. So we need to also pass the
corresponding keyup events.
Fixes #1522.
|
|
|
|
|
|
|
|
|
|
This is @mrmr1993's work from #1041.
Reload content scripts when vimium is installed or updates.
(@mrmr1993: The automatic merge was really messy (or, at least, I
couldn't figure out what was going on). Since the bulk of #1041 was
actually quite compact, I took the liberty of just copying it in. Hope
you don't mind.)
|
|
|
|
|
|
This delivers a "hidden" massage to the vomnibar after the vomnibar has
been hiddent in the host page. The vomnibar only performs whatever
action is required when it receives this "hidden" message.
|
|
Fix oversight from #1517.
|
|
This is not entirely satisfactory. It would be great if a delay of 0
worked (a la `nextTick`). But it seems we need a little longer because
we need to allow the UI component messaging to complete.
An alternative would be to thread the action required through the UI
component logic. But that's pretty ugly too.
Yet another alternative would be to have the UI Component post an "ok,
we're done, do it" message once the UI component has been removed.
Fixes #1485.
|
|
|
|
|
|
Mainly fix the indentation on comments. Also tweak wording a bid.
|
|
Click:
- in the vomnibar focuses the input
- anywhere else (such as in the space below the vomnibar) hides the
vomnibar.
This makes clicks in the space below the vomnibar behave the same as
clicks in the page itself... Which makes sense, because the difference
is not apparent to the user.
|
|
Fixes #1506.
This takes the opposite approach to #1511. Instead of hiding the
vomnibar when it blurs, we hide it when it's host frame is focused.
|
|
This is a quick fix only (to keep master in a functional state).
openUrlInNewTab is broken, and needs to be refactored.
|
|
|
|
|
|
|
|
|
|
|
|
This only effects link hints with "Use the link's name and numbers for
link-hint filtering" enabled.
We have been matching the *entire text content* of each link-hint
element.
With two (or more) hints, and with one of the elements a descendent of
the other, we have been using the entire text content of the outer node
(which includes the text content of the inner node). This leads to odd
situations where the inner element cannot be selected just by typing its
text, because its text is a substring of the outer element's text.
For example, on Google calendar, the "Today" button shows up as two
hints, one inside the other. Typing "today" never disambiguates the
hint. You always have to hit enter.
There's another nasty example on feedly, where an outer container is
clickable, but its text contains all of the (many) texts of the (many)
contained links. So the hint always has to be selected manually.
Here, when generating the text for an element, we exclude the texts from
any descendent node which has already been considered.
|
|
- This fix enables `2t` to open two new tabs, even in incognito.
Include callback in the call chain so that numbered commands can work.
|
|
This adds another handler which is delivered to the options page, but
for which there is no handler. This was causing an exception on the
background page (console).
|
|
Following on from c8d984520f5de4b3e702cee992c7ecc4f4f49435, I forgot to
fix up the other call to setBadge.
|
|
Fixes #1491.
|
|
- Change openUrlInNewTab to pass tab.windowId
Why? Work around for upstream bug #308171
- Change createTab to use openUrlInNewTab
Why? Fix issue #1507 to open new tab in current window
(Note: This commit removes noise from the code and explains the changes)
|
|
- Change openUrlInNewTab to pass selected tab.windowId
- Change createTab to use openUrlInNewTab
|
