diff options
| -rw-r--r-- | lib/settings.coffee | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/lib/settings.coffee b/lib/settings.coffee index 68333cae..da45eb61 100644 --- a/lib/settings.coffee +++ b/lib/settings.coffee @@ -170,7 +170,7 @@ Settings = newTabUrl: "chrome://newtab" grabBackFocus: false regexFindMode: false - waitForEnterForFilteredHints: false + waitForEnterForFilteredHints: false # Note: this defaults to true for new users; see below. settingsVersion: Utils.getCurrentVersion() helpDialog_showAdvancedCommands: false @@ -182,6 +182,15 @@ Settings.init() # Perform migration from old settings versions, if this is the background page. if Utils.isBackgroundPage() + if not Settings.get "settingsVersion" + # This is a new install. For some settings, we retain a legacy default behaviour for existing users but + # use a non-default behaviour for new users. + + # For waitForEnterForFilteredHints, we (smblott) think that "true" gives a better UX; see #1950. However, + # forcing the change on existing users would be unnecessarily disruptive. So, only new users default to + # "true". + Settings.set "waitForEnterForFilteredHints", true + # We use settingsVersion to coordinate any necessary schema changes. Settings.set("settingsVersion", Utils.getCurrentVersion()) |