diff options
| -rw-r--r-- | content_scripts/link_hints.coffee | 2 | ||||
| -rw-r--r-- | content_scripts/ui_component.coffee | 1 | ||||
| -rw-r--r-- | content_scripts/vimium_frontend.coffee | 4 | ||||
| -rw-r--r-- | lib/dom_utils.coffee | 12 |
4 files changed, 10 insertions, 9 deletions
diff --git a/content_scripts/link_hints.coffee b/content_scripts/link_hints.coffee index 3b607e8e..54c10284 100644 --- a/content_scripts/link_hints.coffee +++ b/content_scripts/link_hints.coffee @@ -127,7 +127,7 @@ class LinkHintsMode # Creates a link marker for the given link. # createMarkerFor: (link) -> - marker = DomUtils.createElement("div") + marker = DomUtils.createElement "div" marker.className = "vimiumReset internalVimiumHintMarker vimiumHintMarker" marker.clickableItem = link.element diff --git a/content_scripts/ui_component.coffee b/content_scripts/ui_component.coffee index a5be78fc..d935079d 100644 --- a/content_scripts/ui_component.coffee +++ b/content_scripts/ui_component.coffee @@ -7,7 +7,6 @@ class UIComponent constructor: (iframeUrl, className, @handleMessage) -> styleSheet = DomUtils.createElement "style" - styleSheet.type = "text/css" # Default to everything hidden while the stylesheet loads. styleSheet.innerHTML = "@import url(\"#{chrome.runtime.getURL("content_scripts/vimium.css")}\");" diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee index 3abd2abb..962b7d6d 100644 --- a/content_scripts/vimium_frontend.coffee +++ b/content_scripts/vimium_frontend.coffee @@ -775,7 +775,7 @@ window.enterFindMode = -> window.showHelpDialog = (html, fid) -> return if (isShowingHelpDialog || !document.body || fid != frameId) isShowingHelpDialog = true - container = DomUtils.createElement("div") + container = DomUtils.createElement "div" container.id = "vimiumHelpDialogContainer" container.className = "vimiumReset" @@ -861,7 +861,7 @@ CursorHider = # See #1345 and #1348. return unless Utils.haveChromeVersion "39.0.2171.71" - @cursorHideStyle = DomUtils.createElement("style") + @cursorHideStyle = DomUtils.createElement "style" @cursorHideStyle.innerHTML = """ body * {pointer-events: none !important; cursor: none !important;} body, html {cursor: none !important;} diff --git a/lib/dom_utils.coffee b/lib/dom_utils.coffee index 8a3969b1..cd9e0405 100644 --- a/lib/dom_utils.coffee +++ b/lib/dom_utils.coffee @@ -12,18 +12,20 @@ DomUtils = element = document.createElement tagName if element.style # The document namespace provides (X)HTML elements, so we can use them directly. + @createElement = document.createElement.bind document element else # The document namespace doesn't give (X)HTML elements, so we create them with the correct namespace # manually. - document.createElementNS "http://www.w3.org/1999/xhtml", tagName + @createElement = document.createElementNS.bind document, "http://www.w3.org/1999/xhtml" + @createElement() # # Adds a list of elements to a page. # Note that adding these nodes all at once (via the parent div) is significantly faster than one-by-one. # addElementList: (els, overlayOptions) -> - parent = DomUtils.createElement("div") + parent = @createElement "div" parent.id = overlayOptions.id if overlayOptions.id? parent.className = overlayOptions.className if overlayOptions.className? parent.appendChild(el) for el in els @@ -246,7 +248,7 @@ DomUtils = # momentarily flash a rectangular border to give user some visual feedback flashRect: (rect) -> - flashEl = DomUtils.createElement("div") + flashEl = @createElement "div" flashEl.id = "vimiumFlash" flashEl.className = "vimiumReset" flashEl.style.left = rect.left + window.scrollX + "px" @@ -307,7 +309,7 @@ DomUtils = 'letterSpacing', 'wordSpacing' ] (element, position) -> - div = DomUtils.createElement "div" + div = @createElement "div" div.id = "vimium-input-textarea-caret-position-mirror-div" document.body.appendChild div @@ -325,7 +327,7 @@ DomUtils = if element.nodeName.toLowerCase() == "input" div.textContent = div.textContent.replace /\s/g, "\u00a0" - span = DomUtils.createElement "span" + span = @createElement "span" span.textContent = element.value.substring(position) || "." div.appendChild span |