diff options
| -rw-r--r-- | README.markdown | 9 | ||||
| -rw-r--r-- | background_page.html | 7 | ||||
| -rw-r--r-- | test_harnesses/automated.html | 2 |
3 files changed, 17 insertions, 1 deletions
diff --git a/README.markdown b/README.markdown index 1a9294f5..54b584c1 100644 --- a/README.markdown +++ b/README.markdown @@ -124,6 +124,15 @@ discussion on the issues tracker or on the [mailing list][list_url]. If it mirro another browser or in Vim itself, let us know! Once you've picked something to work on, add a comment to the respective issue so others don't duplicate your effort. +Please ensure that existing tests pass. The tests are defined in `test_harnesses/automated.html`. To run the +tests: +1. Go to the extensions page +2. Click on the arrow beside Vimium to expand the menu, and then inspect `background_page.html` in the console +3. Type in `runTests()`. + +We encourage you to write tests for any new features or bugfixes. Contributing more tests for existing +features is great too! + When you're done, send us a pull request on Github. Feel free to include a change to the CREDITS file with your patch. diff --git a/background_page.html b/background_page.html index 7d8f749d..4421ae2f 100644 --- a/background_page.html +++ b/background_page.html @@ -765,6 +765,13 @@ }); } init(); + + /** + * Convenience function for development use. + */ + function runTests() { + open(chrome.extension.getURL('test_harnesses/automated.html')); + } </script> </head> </html> diff --git a/test_harnesses/automated.html b/test_harnesses/automated.html index 9f1b8007..e7d84413 100644 --- a/test_harnesses/automated.html +++ b/test_harnesses/automated.html @@ -117,7 +117,7 @@ }), should("label the hints correctly", function() { - var hintStrings = ["ss", "sa", "sd"]; + var hintStrings = ["ss", "as", "ds"]; for (var i = 0; i < 3; i++) assert.equal(hintStrings[i], linkHints.hintMarkers[i].getAttribute("hintString")); }), |