diff options
| author | Stephen Blott | 2016-03-13 08:10:23 +0000 |
|---|---|---|
| committer | Stephen Blott | 2016-03-28 05:45:38 +0100 |
| commit | b7f0487d32dd50b73cf7729bbb4a900db9b786c8 (patch) | |
| tree | 29fe9d8078bd31454f2346403220ac24272b2b46 /tests | |
| parent | 6271ce2ba4e73c7506f638113660a5fb1e66e999 (diff) | |
| download | vimium-b7f0487d32dd50b73cf7729bbb4a900db9b786c8.tar.bz2 | |
Global link hints; revert b7535a604954b5873d825eb66bfecd08f1f2c99b.
Here's why:
- b7535a604954b5873d825eb66bfecd08f1f2c99b is complicated and complex (O(n^2)).
- With experience, it is not obviously better than what was there
before, and in some cases it's worse.
- b7535a604954b5873d825eb66bfecd08f1f2c99b selects way too much text in
some cases; e.g. on Google Inbox, it selects text lengths in the tens
of thousands of characters. That cannot be useful.
- With global hints, this extra cost (resulting from passing large
objects between frames) is significant and noticable.
- The simpler approach of accounting for text length when scoring
filtered hints (tweaked here: 5cbc5ad702a01a81b98f8c82edb3b6d227c2c7b5)
works better in practice.
Diffstat (limited to 'tests')
0 files changed, 0 insertions, 0 deletions
