aboutsummaryrefslogtreecommitdiffstats
path: root/pages
diff options
context:
space:
mode:
authorStephen Blott2016-04-18 10:28:22 +0100
committerStephen Blott2016-04-18 10:28:25 +0100
commit20c1fef75eef7a203cc550f2d035ee5c82be5bd6 (patch)
treebcc52c4f36af7f00ad1adb94526ba9e8d7b29ee6 /pages
parent61e94c77d37011f675478c95b33ccd1dcf70ca6d (diff)
downloadvimium-20c1fef75eef7a203cc550f2d035ee5c82be5bd6.tar.bz2
Simplify find-mode exit event.
Previously, we were transferring a "transferable event" from the HUD UI component to the content script (when find mode exits). In addition to being unnecessary, this was triggering a warning in the console because we were reading *all* of the events keys, including one which triggers a "this is being deprecated" warning. The approach here is simpler, transfers less data and avoids triggering the warning.
Diffstat (limited to 'pages')
-rw-r--r--pages/hud.coffee7
1 files changed, 2 insertions, 5 deletions
diff --git a/pages/hud.coffee b/pages/hud.coffee
index fcc7b1dd..6eaa5f9c 100644
--- a/pages/hud.coffee
+++ b/pages/hud.coffee
@@ -15,18 +15,15 @@ setTextInInputElement = (inputElement, text) ->
document.addEventListener "keydown", (event) ->
inputElement = document.getElementById "hud-find-input"
return unless inputElement? # Don't do anything if we're not in find mode.
- transferrableEvent = {}
- # NOTE(mrmr1993): We use for, not for own, here, since we want to access members from the Event prototype.
- for key, value of event
- transferrableEvent[key] = value if typeof value in ["number", "string"]
if (event.keyCode in [keyCodes.backspace, keyCodes.deleteKey] and inputElement.textContent.length == 0) or
event.keyCode == keyCodes.enter or KeyboardUtils.isEscape event
UIComponentServer.postMessage
name: "hideFindMode"
- event: transferrableEvent
query: findMode.rawQuery
+ exitEventIsEnter: event.keyCode == keyCodes.enter
+ exitEventIsEscape: KeyboardUtils.isEscape event
else if event.keyCode == keyCodes.upArrow
if rawQuery = FindModeHistory.getQuery findMode.historyIndex + 1