diff options
| author | mrmr1993 | 2016-02-11 05:01:50 +0000 |
|---|---|---|
| committer | mrmr1993 | 2016-02-11 05:01:50 +0000 |
| commit | 2922fdf80f21d36acd12501dd1b3264377a95895 (patch) | |
| tree | 88e51e6a95d31debeb0373d00f95a0acfff8827b /pages | |
| parent | 9a7456334fca81dff41fea6a2701365806f6c3b3 (diff) | |
| download | vimium-2922fdf80f21d36acd12501dd1b3264377a95895.tar.bz2 | |
Add a comment explaining why HelpDialog has seemingly redundant fields
Diffstat (limited to 'pages')
| -rw-r--r-- | pages/help_dialog.coffee | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/pages/help_dialog.coffee b/pages/help_dialog.coffee index a25edaab..e2f5220f 100644 --- a/pages/help_dialog.coffee +++ b/pages/help_dialog.coffee @@ -1,3 +1,9 @@ +# This overrides the HelpDialog implementation in vimium_frontend.coffee, which prevents us from being able +# to spawn a help dialog within the help dialog UIComponent. As such, we need to provide all the properties +# that we expect on the normal HelpDialog implementation. +# +# NOTE(mrmr1993): In the future, we can move to a single help dialog UIComponent per tab (ie. in the +# top-level frame), and then we don't need to be concerned about nested help dialog frames. HelpDialog = dialogElement: null showing: true |