diff options
| author | Stephen Blott | 2017-09-15 10:39:44 +0100 |
|---|---|---|
| committer | Stephen Blott | 2017-09-15 10:42:58 +0100 |
| commit | c363e4b18eee636f7cc9ef48473ba6d610e06220 (patch) | |
| tree | 529fc55852c805195e053f39af8a3522400d5e33 /pages/help_dialog.coffee | |
| parent | a36768439ae253fb42131fbb205e78ac8d298b68 (diff) | |
| download | vimium-c363e4b18eee636f7cc9ef48473ba6d610e06220.tar.bz2 | |
Use .textContent instead of .innerHTML, where appropriate.
From a FF extension reviewer (gatekeeper) on Mozilla add-ons:
Comments:
Thank you for your contribution.
Please note the following for the next update:
1) For inserting text, textContent (or JQuery text) or createTextNode() should be used instead of innerHTML.
eg: $("saveOptions").innerHTML = "Save Changes";
So, here, `.innerHTML` is replaced with `.textContent` for elements
which only ever have text content.
Diffstat (limited to 'pages/help_dialog.coffee')
| -rw-r--r-- | pages/help_dialog.coffee | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/pages/help_dialog.coffee b/pages/help_dialog.coffee index 4ac9116b..a0ad1af8 100644 --- a/pages/help_dialog.coffee +++ b/pages/help_dialog.coffee @@ -73,7 +73,7 @@ HelpDialog = for key in command.keys.sort compareKeys @instantiateHtmlTemplate keysElement, "#keysTemplate", (element) -> lastElement = element - $$(element, ".vimiumHelpDialogKey").innerHTML = Utils.escapeHtml key + $$(element, ".vimiumHelpDialogKey").textContent = key # And strip off the trailing ", ", if necessary. lastElement.removeChild $$ lastElement, ".commaSeparator" if lastElement @@ -109,7 +109,7 @@ HelpDialog = vimiumHelpDialogContainer.scrollTop += scrollHeightDelta if 0 < scrollHeightDelta showAdvancedCommands: (visible) -> - document.getElementById("toggleAdvancedCommands").innerHTML = + document.getElementById("toggleAdvancedCommands").textContent = if visible then "Hide advanced commands" else "Show advanced commands" # Add/remove the showAdvanced class to show/hide advanced commands. |