aboutsummaryrefslogtreecommitdiffstats
path: root/linkHints.js
diff options
context:
space:
mode:
authorJez Ng2012-01-23 06:41:21 -0500
committerJez Ng2012-01-23 06:41:21 -0500
commitccba059c287726002173a4d3ef16df6dfe52d06a (patch)
tree4c65ab85693ae21ede53c50d780937b1b3728cce /linkHints.js
parentfb99302b22ddcc7a2ecd7c21e43f3548d937701d (diff)
downloadvimium-ccba059c287726002173a4d3ef16df6dfe52d06a.tar.bz2
Revert "Optimize hint generation."
This reverts commit f1e92dfe796eb487c9cec41038d8ad7bd99242db. The apparent improvements in performance do not seem to be reproducible.
Diffstat (limited to 'linkHints.js')
-rw-r--r--linkHints.js20
1 files changed, 8 insertions, 12 deletions
diff --git a/linkHints.js b/linkHints.js
index 53a31f2b..e72c3f7f 100644
--- a/linkHints.js
+++ b/linkHints.js
@@ -319,7 +319,7 @@ var alphabetHints = {
for (var i = 0, count = visibleElements.length; i < count; i++) {
var marker = hintUtils.createMarkerFor(visibleElements[i]);
marker.hintString = hintStrings[i];
- hintUtils.spanWrap(marker, marker.hintString.toUpperCase());
+ marker.innerHTML = hintUtils.spanWrap(marker.hintString.toUpperCase());
hintMarkers.push(marker);
}
@@ -471,7 +471,8 @@ var filterHints = {
},
renderMarker: function(marker) {
- hintUtils.spanWrap(marker, marker.hintString + (marker.showLinkText ? ": " + marker.linkText : ""));
+ marker.innerHTML = hintUtils.spanWrap(marker.hintString +
+ (marker.showLinkText ? ": " + marker.linkText : ""));
},
getHintMarkers: function(visibleElements) {
@@ -573,16 +574,11 @@ var hintUtils = {
/*
* Make each hint character a span, so that we can highlight the typed characters as you type them.
*/
- spanWrap: function(marker, hintString) {
- while (marker.childNodes.length > 0)
- marker.removeChild(marker.lastChild);
-
- for (var i = 0; i < hintString.length; i++) {
- var span = document.createElement("span");
- span.className = "vimiumReset";
- span.textContent = hintString[i];
- marker.appendChild(span);
- }
+ spanWrap: function(hintString) {
+ var innerHTML = [];
+ for (var i = 0; i < hintString.length; i++)
+ innerHTML.push("<span class='vimiumReset'>" + hintString[i] + "</span>");
+ return innerHTML.join("");
},
/*