aboutsummaryrefslogtreecommitdiffstats
path: root/lib/dom_utils.coffee
diff options
context:
space:
mode:
authormrmr19932016-02-26 19:52:51 +0000
committermrmr19932016-02-26 19:55:24 +0000
commit2a631ab75bc23a30f890fa5c557c684225b7bb81 (patch)
tree249b097efc179e85d4518d1c26531031d083abf8 /lib/dom_utils.coffee
parente33fbadb834f3f51599780eab9a7d85244a1b380 (diff)
downloadvimium-2a631ab75bc23a30f890fa5c557c684225b7bb81.tar.bz2
Remove outdated blacklist in DomUtils.isEditable, use .isSelectable
This fixes #1964.
Diffstat (limited to 'lib/dom_utils.coffee')
-rw-r--r--lib/dom_utils.coffee7
1 files changed, 1 insertions, 6 deletions
diff --git a/lib/dom_utils.coffee b/lib/dom_utils.coffee
index db90c43a..7f18e643 100644
--- a/lib/dom_utils.coffee
+++ b/lib/dom_utils.coffee
@@ -179,12 +179,7 @@ DomUtils =
# enter insert mode if focused. Also note that the "contentEditable" attribute can be set on any element
# which makes it a rich text editor, like the notes on jjot.com.
isEditable: (element) ->
- return true if element.isContentEditable
- nodeName = element.nodeName?.toLowerCase()
- # Use a blacklist instead of a whitelist because new form controls are still being implemented for html5.
- if nodeName == "input" and element.type not in ["radio", "checkbox"]
- return true
- nodeName in ["textarea", "select"]
+ (@isSelectable element) or element.nodeName?.toLowerCase() == "select"
# Embedded elements like Flash and quicktime players can obtain focus.
isEmbed: (element) ->