diff options
| author | Björn | 2012-04-27 21:23:45 +0200 |
|---|---|---|
| committer | Jez Ng | 2012-04-27 16:19:37 -0400 |
| commit | 36ba08a4e14f7de05b3357b35666e7351083998d (patch) | |
| tree | 093e4ac40253e0e16e0ada6978ee27b682de32c5 /lib/domUtils.js | |
| parent | c4ed266304234788160bd1ede5370432c8710675 (diff) | |
| download | vimium-36ba08a4e14f7de05b3357b35666e7351083998d.tar.bz2 | |
flashElement: use an overlay, so zero-sized links are flashed as well
(no css manupulation of the target element)
Conflicts:
lib/domUtils.js
Diffstat (limited to 'lib/domUtils.js')
| -rw-r--r-- | lib/domUtils.js | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/lib/domUtils.js b/lib/domUtils.js index ee17d45f..06bffa42 100644 --- a/lib/domUtils.js +++ b/lib/domUtils.js @@ -106,10 +106,15 @@ var domUtils = { }, // momentarily flash a border around an element to give user some visual feedback - flashElement: function(element) { - var oldBorderValue = element.style.border; - element.style.border = '1px solid #66f'; - setTimeout(function(){element.style.border = oldBorderValue;}, 400); + flashElement: function(element, rect) { + var flashEl = document.createElement("div"); + flashEl.id = "vimiumFlash"; + flashEl.style.left = rect.left + window.scrollX + "px"; + flashEl.style.top = rect.top + window.scrollY + "px"; + flashEl.style.width = rect.width + "px"; + flashEl.style.height = rect.height + "px"; + document.body.appendChild(flashEl); + setTimeout(function() { flashEl.parentNode.removeChild(flashEl); delete flashEl; }, 400); }, }; |
