diff options
| author | Stephen Blott | 2016-12-26 06:17:30 +0000 |
|---|---|---|
| committer | Stephen Blott | 2016-12-26 06:17:30 +0000 |
| commit | 4855173ec4e8e9852c4a6d51be0a8a5519e9daba (patch) | |
| tree | 5113d7c2dedf59a22439d4725f96860cd181e74b /background_scripts | |
| parent | 4a54a75fe1f987b1ccc266fbeaf2a2078a8e1508 (diff) | |
| download | vimium-4855173ec4e8e9852c4a6d51be0a8a5519e9daba.tar.bz2 | |
Fix (another) infinite-scroll issue.
Steps to reproduce:
- Press and hold `j`.
- Tab `k`.
- Release `j`.
The tap on `k` is uninstalling the `cancelEventListener` installed by
`j`, and because we advance `@time`, the `j` stops scrolling and
removes the `cancelEventListener` installed for `k`. So we end up with
no `cancelEventListener` installed.
The fix is to make the `cancelEventListener` specific to the scroller
instance.
The more fundamental problem here is that we're mixing dynamic and
static state. A better approach would be to have `CoreScroller` as a
class, with a new instance created for each scroll instance.
Diffstat (limited to 'background_scripts')
0 files changed, 0 insertions, 0 deletions
