diff options
| author | Stephen Blott | 2016-04-03 06:21:44 +0100 |
|---|---|---|
| committer | Stephen Blott | 2016-04-03 06:33:18 +0100 |
| commit | 9d3e6cc399e69aec49ff59e78e58d403fe0bdf4b (patch) | |
| tree | 7d022f9fcf6dc3c1d8b12b2eb0c552021daa3b92 /background_scripts | |
| parent | 96c74e4aa7e39a99bf5511440ba7a4155f1e2db8 (diff) | |
| download | vimium-9d3e6cc399e69aec49ff59e78e58d403fe0bdf4b.tar.bz2 | |
Remove blocking mode when no hints found.
This fixes an error in 39adee9090fc5aadfd5dd681f91b80025084858a.
Specifically, if there are no hints to select from, or no
documentElement, then link-hints mode exits without initiating an actual
mode (i.e. without calling its super() constructor).
With 39adee9090fc5aadfd5dd681f91b80025084858a, that leaves a mode in
place which blocks all keyboard events, thereby rendering Vimium
entirely hung.
See this line:
https://github.com/philc/vimium/commit/39adee9090fc5aadfd5dd681f91b80025084858a#diff-e9abcb9ebcdb5af8e9f33651364673a1R59.
Here:
- we explicitly remove the keyboard-blocking mode
- we add exitOnEscape (so that the situation is at least
recoverable), and
- we add an indicator (so that we can see what's going on).
It is proposed that the indicator is a temporary feature, while the
global link hints feature is in shake down.
Diffstat (limited to 'background_scripts')
0 files changed, 0 insertions, 0 deletions