diff options
| author | Stephen Blott | 2016-05-14 07:35:31 +0100 |
|---|---|---|
| committer | Stephen Blott | 2016-05-15 07:10:26 +0100 |
| commit | a5262f4e68f62a922c9c05d871c4a874f6737a7b (patch) | |
| tree | 9a1bd8927b8d5bed212891839c49a5899789690c /background_scripts/commands.coffee | |
| parent | a1c00c38abee530f84572c36c7422e4ee793316b (diff) | |
| download | vimium-a5262f4e68f62a922c9c05d871c4a874f6737a7b.tar.bz2 | |
Use event.key (not event.keyIdentifier).
event.keyIdentifier is depricated and will be removed soon. It is being
replaced by event.key. Unfortunatelty, event.key is not yet available
in the stable Chrome version.
Here, we use whichever API is available. In due course, we can remove
the event.keyIdentifier implementation (and a considerable amount of
machinery surrounding it).
For the time being, if both APIs are available, then we verify one
against the other and show a warning message of they do not match. This
should help us track down any issues which arise.
Using event.key has the additional benefit of correctly detecting
shifted characters on the numbers row on keydown, which has been a
problem for some users.
Fixes #2128.
Note: We have a problem with the tests. phantomjs does not currently
support event.key, and possibly never will.
Diffstat (limited to 'background_scripts/commands.coffee')
0 files changed, 0 insertions, 0 deletions