diff options
| author | Stephen Blott | 2017-12-16 11:24:12 +0000 |
|---|---|---|
| committer | Stephen Blott | 2017-12-16 11:24:12 +0000 |
| commit | 1b23f70fa75592422056342cd7d9297d0804ea3f (patch) | |
| tree | 9c95358fc3144dc65bab27851b4d9850706a4ecb | |
| parent | b6a0bd0cf29fc3621f4c337616ed119f239c0ed0 (diff) | |
| download | vimium-1b23f70fa75592422056342cd7d9297d0804ea3f.tar.bz2 | |
Do not open tab for target "_blank".
Fixes #2860. That issue reports that, when the target is "_blank",
Firefox/Vimium ends up opening two tabs.
| -rw-r--r-- | lib/dom_utils.coffee | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/dom_utils.coffee b/lib/dom_utils.coffee index 67d5a44c..ebd9cf3d 100644 --- a/lib/dom_utils.coffee +++ b/lib/dom_utils.coffee @@ -250,7 +250,7 @@ DomUtils = eventSequence = ["mouseover", "mousedown", "mouseup", "click"] for event in eventSequence defaultActionShouldTrigger = @simulateMouseEvent event, element, modifiers - if event == "click" and defaultActionShouldTrigger and Utils.isFirefox() + if event == "click" and defaultActionShouldTrigger and Utils.isFirefox() and element.target != "_blank" # Firefox doesn't (currently) trigger the default action for modified keys. DomUtils.simulateClickDefaultAction element, modifiers defaultActionShouldTrigger # return the values returned by each @simulateMouseEvent call. |