diff options
| author | mrmr1993 | 2017-11-14 12:07:26 +0000 |
|---|---|---|
| committer | mrmr1993 | 2017-11-14 12:07:26 +0000 |
| commit | 64995cc4f4777a3b1899caaf2992862f9f02448b (patch) | |
| tree | cf812a896fdb35e02a7d9d817d000e20f43803b2 | |
| parent | 1880062f68e6f4280b7257f3cd437c0aee7c9696 (diff) | |
| download | vimium-64995cc4f4777a3b1899caaf2992862f9f02448b.tar.bz2 | |
Don't suppress default action for non-printing keys in link hints
This restores the old behaviour prior to
c4cc76e9f6a0a99ebc297e420be739a0fc77f827 (PR #2772).
| -rw-r--r-- | content_scripts/link_hints.coffee | 2 | ||||
| -rw-r--r-- | lib/dom_utils.coffee | 8 |
2 files changed, 7 insertions, 3 deletions
diff --git a/content_scripts/link_hints.coffee b/content_scripts/link_hints.coffee index f2fb7c19..ec3c685a 100644 --- a/content_scripts/link_hints.coffee +++ b/content_scripts/link_hints.coffee @@ -294,7 +294,7 @@ class LinkHintsMode @markerMatcher.pushKeyChar keyChar @updateVisibleMarkers() else - return + return handlerStack.suppressPropagation handlerStack.suppressEvent diff --git a/lib/dom_utils.coffee b/lib/dom_utils.coffee index 95b9f4b3..67d5a44c 100644 --- a/lib/dom_utils.coffee +++ b/lib/dom_utils.coffee @@ -363,8 +363,12 @@ DomUtils = @remove() if event.target == window handlerStack.continueBubbling callback?() - @suppressEvent event - handlerStack.suppressEvent + if suppressPropagation + DomUtils.suppressPropagation event + handlerStack.suppressPropagation + else + DomUtils.suppressEvent event + handlerStack.suppressEvent # Polyfill for selection.type (which is not available in Firefox). getSelectionType: (selection = document.getSelection()) -> |