diff options
| author | Phil Crosby | 2014-08-12 08:17:42 -0700 |
|---|---|---|
| committer | Phil Crosby | 2014-08-12 08:17:42 -0700 |
| commit | 5b53d69d2698e65204413711675770b017d02883 (patch) | |
| tree | 70c2d6efea74214f3c165482725d620cbdc20b40 | |
| parent | 880a5d28ef9c3bb647b8f70e607e8e132d02a278 (diff) | |
| parent | 17d7b88ee05ee940404fef5bb605c9b7665b15b8 (diff) | |
| download | vimium-5b53d69d2698e65204413711675770b017d02883.tar.bz2 | |
Merge pull request #1116 from vincentbernat/fix/link-gonext
Match mixed-case relationship links in goNext/goPrevious
| -rw-r--r-- | content_scripts/vimium_frontend.coffee | 2 | ||||
| -rw-r--r-- | tests/dom_tests/dom_tests.coffee | 23 |
2 files changed, 24 insertions, 1 deletions
diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee index e45c4dfe..896253a6 100644 --- a/content_scripts/vimium_frontend.coffee +++ b/content_scripts/vimium_frontend.coffee @@ -811,7 +811,7 @@ findAndFollowRel = (value) -> for tag in relTags elements = document.getElementsByTagName(tag) for element in elements - if (element.hasAttribute("rel") && element.rel == value) + if (element.hasAttribute("rel") && element.rel.toLowerCase() == value) followLink(element) return true diff --git a/tests/dom_tests/dom_tests.coffee b/tests/dom_tests/dom_tests.coffee index 04c81068..0b2a9d89 100644 --- a/tests/dom_tests/dom_tests.coffee +++ b/tests/dom_tests/dom_tests.coffee @@ -215,6 +215,29 @@ context "Find prev / next links", goNext() assert.equal '#second', window.location.hash + should "find link relation in header", -> + document.getElementById("test-div").innerHTML = """ + <link rel='next' href='#first'> + """ + goNext() + assert.equal '#first', window.location.hash + + should "favor link relation to text matching", -> + document.getElementById("test-div").innerHTML = """ + <link rel='next' href='#first'> + <a href='#second'>next</a> + """ + goNext() + assert.equal '#first', window.location.hash + + should "match mixed case link relation", -> + document.getElementById("test-div").innerHTML = """ + <link rel='Next' href='#first'> + """ + goNext() + assert.equal '#first', window.location.hash + + createLinks = (n) -> for i in [0...n] by 1 link = document.createElement("a") |