diff options
| author | Stephen Blott | 2016-04-11 06:19:26 +0100 |
|---|---|---|
| committer | Stephen Blott | 2016-04-11 06:19:26 +0100 |
| commit | 931e1b73a518b8c40671ec90331403aaae5e5b46 (patch) | |
| tree | 1a23a067ab1e2ca2e5ab5c28296db2072262a053 | |
| parent | 09e119db8d8c3ad2077ac509f73fefb76a08fac0 (diff) | |
| download | vimium-931e1b73a518b8c40671ec90331403aaae5e5b46.tar.bz2 | |
Revert always initialize help dialog.
Here's the trade off... We either *always* initialize the help dialog in
every frame of every tab, or we initialize it only when needed.
The help dialog is rarely used by anybody except beginners, so the
latter seems like the better approach. However, on busy/slow loading
pages, the help dialog can fail to load on page start up. (We need to
fix this, but I don't know how right now). In the meantime, the better
compromise seems to be to initialize the help dialog only when needed.
This was the status quo prior to 6e12e005a4261711583571be23018481a4a23230
and 09e119db8d8c3ad2077ac509f73fefb76a08fac0.
| -rw-r--r-- | content_scripts/vimium_frontend.coffee | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee index a515d55c..6fb30dec 100644 --- a/content_scripts/vimium_frontend.coffee +++ b/content_scripts/vimium_frontend.coffee @@ -140,7 +140,6 @@ initializeOnEnabledStateKnown = Utils.makeIdempotent -> initializeUIComponents = Utils.makeIdempotent -> DomUtils.documentReady -> HUD.init() - HelpDialog.init() Vomnibar.init() if DomUtils.isTopFrame() # @@ -636,7 +635,7 @@ window.HelpDialog ?= @helpUI = new UIComponent "pages/help_dialog.html", "vimiumHelpDialogFrame", (event) => @hide() if event.data == "hide" - isReady: -> @helpUI?.uiComponentIsReady + isReady: -> @helpUI show: (html) -> @init() |