aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Blott2016-03-28 09:35:06 +0100
committerStephen Blott2016-03-28 09:35:06 +0100
commit359cb9f245a37c3843f24caeed0e0d5604b28379 (patch)
treeb75146973a525eea672d903d1197636ad680f1d3
parente30811c15704144042f2af8a418877d3e4f0297f (diff)
downloadvimium-359cb9f245a37c3843f24caeed0e0d5604b28379.tar.bz2
Disable Ctrl modifier for filtered hints.
-rw-r--r--content_scripts/link_hints.coffee8
1 files changed, 7 insertions, 1 deletions
diff --git a/content_scripts/link_hints.coffee b/content_scripts/link_hints.coffee
index 17767d29..49103976 100644
--- a/content_scripts/link_hints.coffee
+++ b/content_scripts/link_hints.coffee
@@ -185,7 +185,13 @@ class LinkHintsMode
previousTabCount = @tabCount
@tabCount = 0
- if event.keyCode in [ keyCodes.shiftKey, keyCodes.ctrlKey ] and
+ # NOTE(smblott) As of 1.54, the Ctrl modifier doesn't work for filtered link hints; therefore we only
+ # offer the control modifier for alphabet hints. It is not clear whether we should fix this. As of
+ # 16-03-28, nobody has complained.
+ modifiers = [keyCodes.shiftKey]
+ modifiers.push keyCodes.ctrlKey unless Settings.get "filterLinkHints"
+
+ if event.keyCode in modifiers and
@mode in [ OPEN_IN_CURRENT_TAB, OPEN_WITH_QUEUE, OPEN_IN_NEW_BG_TAB, OPEN_IN_NEW_FG_TAB ]
@tabCount = previousTabCount
# Toggle whether to open the link in a new or current tab.