diff options
| author | Stephen Blott | 2015-06-01 12:26:16 +0100 |
|---|---|---|
| committer | Stephen Blott | 2015-06-01 12:26:18 +0100 |
| commit | f50d3add7e6c95a5fc2945e067a52634a19c8a65 (patch) | |
| tree | b1dfb4c477849e68eec92aee3610a1758e79b77e | |
| parent | 971b2fbd6b45ff701ed2dc61fadfb4e7a2f20193 (diff) | |
| download | vimium-f50d3add7e6c95a5fc2945e067a52634a19c8a65.tar.bz2 | |
Note bug in settings.
(This bug has been around for quite some time. I just noticed it now.)
| -rw-r--r-- | lib/settings.coffee | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/settings.coffee b/lib/settings.coffee index ca41ced7..343f782a 100644 --- a/lib/settings.coffee +++ b/lib/settings.coffee @@ -55,6 +55,8 @@ Settings = set: (key, value) -> # Don't store the value if it is equal to the default, so we can change the defaults in the future. + # FIXME(smblott). This test is broken for exclusionRules (for which it is never true). In this case, we + # need some kind of structural equality (or perhaps comparison of JSONified strings). if value == @defaults[key] @clear key else |