aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Blott2015-06-16 07:06:27 +0100
committerStephen Blott2015-06-16 07:06:27 +0100
commitba07f147a3a8fa76a15dd780513fd6352fc6298e (patch)
treee90d5a8789a84f1636c97cb9a5db85493cf1dbc4
parentaa00e29dc2533b6701c65935223599671c5833b1 (diff)
downloadvimium-ba07f147a3a8fa76a15dd780513fd6352fc6298e.tar.bz2
Make "Show Advanced Options" state persistent.
-rw-r--r--lib/settings.coffee1
-rw-r--r--pages/options.coffee26
-rw-r--r--pages/options.html2
3 files changed, 16 insertions, 13 deletions
diff --git a/lib/settings.coffee b/lib/settings.coffee
index 842f7618..c1caecd3 100644
--- a/lib/settings.coffee
+++ b/lib/settings.coffee
@@ -150,6 +150,7 @@ Settings =
settingsVersion: Utils.getCurrentVersion()
helpDialog_showAdvancedCommands: false
+ optionsPage_showAdvancedOptions: false
Settings.init()
diff --git a/pages/options.coffee b/pages/options.coffee
index 21e81c8f..88acbf51 100644
--- a/pages/options.coffee
+++ b/pages/options.coffee
@@ -197,18 +197,20 @@ initOptionsPage = ->
show $("linkHintCharacters")
hide $("linkHintNumbers")
- toggleAdvancedOptions =
- do (advancedMode=false) ->
- (event) ->
- if advancedMode
- $("advancedOptions").style.display = "none"
- $("advancedOptionsButton").innerHTML = "Show Advanced Options"
- else
- $("advancedOptions").style.display = "table-row-group"
- $("advancedOptionsButton").innerHTML = "Hide Advanced Options"
- advancedMode = !advancedMode
- $("advancedOptionsButton").blur()
- event.preventDefault()
+ maintainAdvancedOptions = ->
+ if bgSettings.get "optionsPage_showAdvancedOptions"
+ $("advancedOptions").style.display = "table-row-group"
+ $("advancedOptionsButton").innerHTML = "Hide Advanced Options"
+ else
+ $("advancedOptions").style.display = "none"
+ $("advancedOptionsButton").innerHTML = "Show Advanced Options"
+ maintainAdvancedOptions()
+
+ toggleAdvancedOptions = (event) ->
+ bgSettings.set "optionsPage_showAdvancedOptions", not bgSettings.get "optionsPage_showAdvancedOptions"
+ maintainAdvancedOptions()
+ $("advancedOptionsButton").blur()
+ event.preventDefault()
activateHelpDialog = ->
showHelpDialog chrome.extension.getBackgroundPage().helpDialogHtml(true, true, "Command Listing"), frameId
diff --git a/pages/options.html b/pages/options.html
index 12a3ad21..22b041b7 100644
--- a/pages/options.html
+++ b/pages/options.html
@@ -283,7 +283,7 @@ b: http://b.com/?q=%s description
</span>
</td>
<td id="saveOptionsTableData" nowrap>
- <button id="advancedOptionsButton">Show Advanced Options</button>
+ <button id="advancedOptionsButton"></button>
<button id="saveOptions" disabled="true">No Changes</button>
</td>
</tr>