aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Blott2015-05-26 06:03:07 +0100
committerStephen Blott2015-05-26 06:03:07 +0100
commit8b57d179a1655dbce081b321445f34a4aad696f4 (patch)
tree2f6fd248014dbbbda576ea4ea82fbbdbc3cad857
parentc614a7f4441bfd46c8851d658bc5598e2465fb74 (diff)
downloadvimium-8b57d179a1655dbce081b321445f34a4aad696f4.tar.bz2
Add comment noting why we need AsyncDataFetcher.
-rw-r--r--content_scripts/ui_component.coffee4
1 files changed, 3 insertions, 1 deletions
diff --git a/content_scripts/ui_component.coffee b/content_scripts/ui_component.coffee
index 31274c3e..24982fa7 100644
--- a/content_scripts/ui_component.coffee
+++ b/content_scripts/ui_component.coffee
@@ -27,7 +27,9 @@ class UIComponent
# Hide the iframe, but don't interfere with the focus.
@hide false
- # Open a port and pass it to the iframe via window.postMessage.
+ # Open a port and pass it to the iframe via window.postMessage. We use an AsyncDataFetcher to handle
+ # requests which arrive before the frame (and its message handlers) have completed initialization. See
+ # #1679.
@iframePort = new AsyncDataFetcher (setIframePort) =>
@iframeElement.addEventListener "load", =>
# Get vimiumSecret so the iframe can determine that our message isn't the page impersonating us.