diff options
| author | Phil Crosby | 2010-01-30 22:17:01 -0800 |
|---|---|---|
| committer | Phil Crosby | 2010-01-31 00:37:08 -0800 |
| commit | 80cbb6c178a7cc98fe244c0410f024cacf9d6694 (patch) | |
| tree | 9f44598c34d2113001c905a216cca7735db30a08 | |
| parent | 29d0b9c2a0fe441a8434ec1882e3dc4b9e3af638 (diff) | |
| download | vimium-80cbb6c178a7cc98fe244c0410f024cacf9d6694.tar.bz2 | |
Recognize elements with "onclick" attributes in link hints.
Fixes #72, although it makes Reddit look pretty messy since each link now has 3 letters.
| -rw-r--r-- | linkHints.js | 2 | ||||
| -rw-r--r-- | test_harnesses/page_with_links.html | 15 |
2 files changed, 13 insertions, 4 deletions
diff --git a/linkHints.js b/linkHints.js index d5ed9352..2c085ff7 100644 --- a/linkHints.js +++ b/linkHints.js @@ -18,7 +18,7 @@ var linkHintsCssAdded = false; // An XPath describing what a clickable element is. We could also look for images with an onclick // attribute, but let's wait to see if that really is necessary. -var clickableElementsXPath = "//a | //textarea | //button | //select | //input[not(@type='hidden')]"; +var clickableElementsXPath = "//a | //textarea | //button | //select | //input[not(@type='hidden')] | //*[@onclick]"; // We need this as a top-level function because our command system doesn't yet support arguments. function activateLinkHintsModeToOpenInNewTab() { activateLinkHintsMode(true); } diff --git a/test_harnesses/page_with_links.html b/test_harnesses/page_with_links.html index 5e0679f4..83937595 100644 --- a/test_harnesses/page_with_links.html +++ b/test_harnesses/page_with_links.html @@ -19,7 +19,7 @@ a#paddingLinkTop { padding-top:50px; } - + </style> </head> <body> @@ -27,7 +27,7 @@ <br/><br/> <br/><br/> - + <a href="#paddingLink" id="paddingLink">This link has a lot of vertical padding</a> <br/><br/> @@ -36,5 +36,14 @@ <br/><br/> <a href="#paddingLinkTop" id="paddingLinkTop">This link has a lot of vertical padding on the top</a> + + <br/><br/> + <br/><br/> + <div onclick="alert('hi')">div with an onclick attribute</div> + + + <br/><br/> + <br/><br/> + <a name="anchorSpot">An anchor with just a name</a> </body> -</html>
\ No newline at end of file +</html> |