diff options
| author | Stephen Blott | 2015-06-20 06:59:13 +0100 |
|---|---|---|
| committer | Stephen Blott | 2015-06-20 06:59:13 +0100 |
| commit | 21a5405e9b12201ed96c7de93d94410a3d448979 (patch) | |
| tree | 1f53ca370a7142457d648b6596b1a2b6c99ead87 | |
| parent | 53e84b4800040fd573c7dce4493eb878ceb93766 (diff) | |
| parent | ba07f147a3a8fa76a15dd780513fd6352fc6298e (diff) | |
| download | vimium-21a5405e9b12201ed96c7de93d94410a3d448979.tar.bz2 | |
Merge pull request #1736 from smblott-github/remember-show-advanced-options-state
Make "Show Advanced Options" state persistent.
| -rw-r--r-- | lib/settings.coffee | 1 | ||||
| -rw-r--r-- | pages/options.coffee | 26 | ||||
| -rw-r--r-- | pages/options.html | 2 |
3 files changed, 16 insertions, 13 deletions
diff --git a/lib/settings.coffee b/lib/settings.coffee index 842f7618..c1caecd3 100644 --- a/lib/settings.coffee +++ b/lib/settings.coffee @@ -150,6 +150,7 @@ Settings = settingsVersion: Utils.getCurrentVersion() helpDialog_showAdvancedCommands: false + optionsPage_showAdvancedOptions: false Settings.init() diff --git a/pages/options.coffee b/pages/options.coffee index 21e81c8f..88acbf51 100644 --- a/pages/options.coffee +++ b/pages/options.coffee @@ -197,18 +197,20 @@ initOptionsPage = -> show $("linkHintCharacters") hide $("linkHintNumbers") - toggleAdvancedOptions = - do (advancedMode=false) -> - (event) -> - if advancedMode - $("advancedOptions").style.display = "none" - $("advancedOptionsButton").innerHTML = "Show Advanced Options" - else - $("advancedOptions").style.display = "table-row-group" - $("advancedOptionsButton").innerHTML = "Hide Advanced Options" - advancedMode = !advancedMode - $("advancedOptionsButton").blur() - event.preventDefault() + maintainAdvancedOptions = -> + if bgSettings.get "optionsPage_showAdvancedOptions" + $("advancedOptions").style.display = "table-row-group" + $("advancedOptionsButton").innerHTML = "Hide Advanced Options" + else + $("advancedOptions").style.display = "none" + $("advancedOptionsButton").innerHTML = "Show Advanced Options" + maintainAdvancedOptions() + + toggleAdvancedOptions = (event) -> + bgSettings.set "optionsPage_showAdvancedOptions", not bgSettings.get "optionsPage_showAdvancedOptions" + maintainAdvancedOptions() + $("advancedOptionsButton").blur() + event.preventDefault() activateHelpDialog = -> showHelpDialog chrome.extension.getBackgroundPage().helpDialogHtml(true, true, "Command Listing"), frameId diff --git a/pages/options.html b/pages/options.html index 12a3ad21..22b041b7 100644 --- a/pages/options.html +++ b/pages/options.html @@ -283,7 +283,7 @@ b: http://b.com/?q=%s description </span> </td> <td id="saveOptionsTableData" nowrap> - <button id="advancedOptionsButton">Show Advanced Options</button> + <button id="advancedOptionsButton"></button> <button id="saveOptions" disabled="true">No Changes</button> </td> </tr> |