Merge pull request #1571 from smblott-github/selection-handling-on-exit-from-visual-mode

Tweak selection handling on exiting visual mode.

1 files changed, 3 insertions, 3 deletions

diff --git a/content_scripts/mode_visual_edit.coffee b/content_scripts/mode_visual_edit.coffee
index a5758a64..f3f754af 100644
--- a/content_scripts/mode_visual_edit.coffee
+++ b/content_scripts/mode_visual_edit.coffee
@@ -366,12 +366,12 @@ class Movement extends CountPrefix
     #
     # End of Movement constructor.
 
-  # Yank the selection; always exits; either deletes the selection or removes it; set @yankedText and return
+  # Yank the selection; always exits; either deletes the selection or collapses it; set @yankedText and return
   # it.
   yank: (args = {}) ->
     @yankedText = @selection.toString()
     @selection.deleteFromDocument() if @options.deleteFromDocument or args.deleteFromDocument
-    @selection.removeAllRanges() unless @options.parentMode
+    @selection.collapseToStart() unless @options.parentMode
 
     message = @yankedText.replace /\s+/g, " "
     message = message[...12] + "..." if 15 < @yankedText.length
@@ -384,7 +384,7 @@ class Movement extends CountPrefix
 
   exit: (event, target) ->
     unless @options.parentMode or @options.oneMovementOnly
-      @selection.removeAllRanges() if event?.type == "keydown" and KeyboardUtils.isEscape event
+      @selection.collapseToStart() if event?.type == "keydown" and KeyboardUtils.isEscape event
 
       # Disabled, pending discussion of fine-tuning the UX.  Simpler alternative is implemented above.
       # # If we're exiting on escape and there is a range selection, then we leave it in place.  However, an