diff options
| author | Stephen Blott | 2014-11-06 15:14:49 +0000 |
|---|---|---|
| committer | Stephen Blott | 2014-11-06 15:14:49 +0000 |
| commit | 9be92a96816839a812decda48be81f3100a86e0f (patch) | |
| tree | 4597b11261788688f681c4c79c8664c6a6f4f340 | |
| parent | d1cf578ea33202c5b94c8a596c254b2ab6eee5da (diff) | |
| parent | 9e8a48457d7bc2939278cc9764c23ad788ac95e7 (diff) | |
| download | vimium-9be92a96816839a812decda48be81f3100a86e0f.tar.bz2 | |
Merge pull request #1226 from mrmr1993/noScrollOverflowHidden
Disable scrolling for `overflow: hidden` elements
| -rw-r--r-- | content_scripts/scroller.coffee | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/content_scripts/scroller.coffee b/content_scripts/scroller.coffee index f3c632b3..8eb50d77 100644 --- a/content_scripts/scroller.coffee +++ b/content_scripts/scroller.coffee @@ -38,7 +38,9 @@ ensureScrollChange = (direction, changeFn) -> element = activatedElement loop oldScrollValue = element[axisName] - changeFn(element, axisName) + overflow = window.getComputedStyle(element, null).getPropertyValue("overflow-#{direction}") + # Elements with `overflow: hidden` don't natively have scrolling, so we shouldn't scroll them. + changeFn(element, axisName) unless overflow == "hidden" break unless (element[axisName] == oldScrollValue && element != document.body) lastElement = element # we may have an orphaned element. if so, just scroll the body element. |