aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorStephen Blott2014-11-18 08:52:24 +0000
committerStephen Blott2014-11-18 08:52:24 +0000
commit11fe107f95dab3a584b7eb4b14a67910d16476be (patch)
tree5772cd3575dfadfb0deb213966720e9f848aa1b0
parent0ba67535c30c601d9f9d2a4158c3637132a976ce (diff)
downloadvimium-11fe107f95dab3a584b7eb4b14a67910d16476be.tar.bz2
Do not handle keystrokes for contentEditable.
-rw-r--r--content_scripts/vimium_frontend.coffee7
1 files changed, 6 insertions, 1 deletions
diff --git a/content_scripts/vimium_frontend.coffee b/content_scripts/vimium_frontend.coffee
index 118f985e..4df24da4 100644
--- a/content_scripts/vimium_frontend.coffee
+++ b/content_scripts/vimium_frontend.coffee
@@ -560,7 +560,12 @@ exitInsertMode = (target) ->
insertModeLock = null
HUD.hide()
-isInsertMode = -> insertModeLock != null
+isInsertMode = ->
+ # In addition to checking insertModeLock, we also need to check whether the active element is
+ # contentEditable because some sites (e.g. inbox.google.com) change the contentEditable attribute on the
+ # fly; see #1245.
+ insertModeLock != null or
+ (document.activeElement and document.activeElement.isContentEditable)
# should be called whenever rawQuery is modified.
updateFindModeQuery = ->