<feed xmlns='http://www.w3.org/2005/Atom'>
<title>vimium/lib, branch 1.56</title>
<subtitle>The hacker's browser.</subtitle>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/vimium/'/>
<entry>
<title>Favour event.keyIdentifier over event.key.</title>
<updated>2016-06-02T05:18:36+00:00</updated>
<author>
<name>Stephen Blott</name>
</author>
<published>2016-06-02T05:18:36+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/vimium/commit/?id=2789c16e25416a6763c075a1b7718973a83403ef'/>
<id>2789c16e25416a6763c075a1b7718973a83403ef</id>
<content type='text'>
See #2147.

Chromium's implementation of event.key currently fails to take account
of keyboard mappings (e.g. neo2).

Here, we favour using event.keyIdentifier (while it's available) as a
workaround.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
See #2147.

Chromium's implementation of event.key currently fails to take account
of keyboard mappings (e.g. neo2).

Here, we favour using event.keyIdentifier (while it's available) as a
workaround.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #2132 from sco-tt/master</title>
<updated>2016-05-27T09:45:45+00:00</updated>
<author>
<name>Stephen Blott</name>
</author>
<published>2016-05-27T09:45:45+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/vimium/commit/?id=176865b667af8d2719416854d79e823873e56b4b'/>
<id>176865b667af8d2719416854d79e823873e56b4b</id>
<content type='text'>
Adds single left/right angle quotation marks to next/previous patterns</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds single left/right angle quotation marks to next/previous patterns</pre>
</div>
</content>
</entry>
<entry>
<title>Also remove event.keyIdentifier in getKeyCharString().</title>
<updated>2016-05-15T06:58:35+00:00</updated>
<author>
<name>Stephen Blott</name>
</author>
<published>2016-05-15T06:58:33+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/vimium/commit/?id=6f08521e946b39ca9254bbc94455641f90f33215'/>
<id>6f08521e946b39ca9254bbc94455641f90f33215</id>
<content type='text'>
This was an oversight from a5262f4e68f62a922c9c05d871c4a874f6737a7b.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This was an oversight from a5262f4e68f62a922c9c05d871c4a874f6737a7b.
</pre>
</div>
</content>
</entry>
<entry>
<title>Use event.key (not event.keyIdentifier).</title>
<updated>2016-05-15T06:10:26+00:00</updated>
<author>
<name>Stephen Blott</name>
</author>
<published>2016-05-14T06:35:31+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/vimium/commit/?id=a5262f4e68f62a922c9c05d871c4a874f6737a7b'/>
<id>a5262f4e68f62a922c9c05d871c4a874f6737a7b</id>
<content type='text'>
event.keyIdentifier is depricated and will be removed soon.  It is being
replaced by event.key.  Unfortunatelty, event.key is not yet available
in the stable Chrome version.

Here, we use whichever API is available.  In due course, we can remove
the event.keyIdentifier implementation (and a considerable amount of
machinery surrounding it).

For the time being, if both APIs are available, then we verify one
against the other and show a warning message of they do not match.  This
should help us track down any issues which arise.

Using event.key has the additional benefit of correctly detecting
shifted characters on the numbers row on keydown, which has been a
problem for some users.

Fixes #2128.

Note:  We have a problem with the tests.  phantomjs does not currently
support event.key, and possibly never will.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
event.keyIdentifier is depricated and will be removed soon.  It is being
replaced by event.key.  Unfortunatelty, event.key is not yet available
in the stable Chrome version.

Here, we use whichever API is available.  In due course, we can remove
the event.keyIdentifier implementation (and a considerable amount of
machinery surrounding it).

For the time being, if both APIs are available, then we verify one
against the other and show a warning message of they do not match.  This
should help us track down any issues which arise.

Using event.key has the additional benefit of correctly detecting
shifted characters on the numbers row on keydown, which has been a
problem for some users.

Fixes #2128.

Note:  We have a problem with the tests.  phantomjs does not currently
support event.key, and possibly never will.
</pre>
</div>
</content>
</entry>
<entry>
<title>Adds single left/right angle quotation marks to next/previous patterns</title>
<updated>2016-05-12T14:44:34+00:00</updated>
<author>
<name>Scott Pinkelman</name>
</author>
<published>2016-05-12T14:44:34+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/vimium/commit/?id=e393159c54d2c09bd228aa1c9d03d1c8e0231091'/>
<id>e393159c54d2c09bd228aa1c9d03d1c8e0231091</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "Improves next/previous links by targetting button elements and adding single left/right angle quotation marks"</title>
<updated>2016-05-12T06:21:07+00:00</updated>
<author>
<name>Stephen Blott</name>
</author>
<published>2016-05-12T06:21:07+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/vimium/commit/?id=22f0ed9c3c63ecbc4fc2413dc5235a9489d9cf25'/>
<id>22f0ed9c3c63ecbc4fc2413dc5235a9489d9cf25</id>
<content type='text'>
This reverts commit ee8c235aeaf52d2bc867a00c37731690e337c7ff.
This reverts #2117.

This breaks next/prev on Reddit (it chooses a different link).

Reddit is an important site, so we should unwind this for now.

Mention @sco-tt.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit ee8c235aeaf52d2bc867a00c37731690e337c7ff.
This reverts #2117.

This breaks next/prev on Reddit (it chooses a different link).

Reddit is an important site, so we should unwind this for now.

Mention @sco-tt.
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge pull request #2118 from smblott-github/fix-ui-component-init-issues</title>
<updated>2016-05-07T03:37:36+00:00</updated>
<author>
<name>Stephen Blott</name>
</author>
<published>2016-05-07T03:37:36+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/vimium/commit/?id=d00cc696c8e43b1b0298bce61fa18e22d78f270d'/>
<id>d00cc696c8e43b1b0298bce61fa18e22d78f270d</id>
<content type='text'>
Fix UI-component initialization issues (maybe).</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix UI-component initialization issues (maybe).</pre>
</div>
</content>
</entry>
<entry>
<title>Fix UI-component initialization issues.</title>
<updated>2016-04-28T12:55:08+00:00</updated>
<author>
<name>Stephen Blott</name>
</author>
<published>2016-04-28T12:51:44+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/vimium/commit/?id=f83e99fd42a4cf412c79fb15c58f59c105c25723'/>
<id>f83e99fd42a4cf412c79fb15c58f59c105c25723</id>
<content type='text'>
This fixes some UI component initialization issues.  It's a long
story...

The problem.

- Go to this page: http://www.thejournal.ie/seanad-election-results-2016-2737768-Apr2016/
- Click one of the links from the "Most Popular" box on the right.
- Navigate back (`H`) and, as the original page is loading, activate the Vomnibar.

In 1.54 this renders Vimium unusable.  In `master` this renders the
Vomnibar unsable, but the rest of Vimium usable.

It seems the source of the issue is that we're initializing UI
components too soon.  We need to wait until the `readyState` is
"complete".

With this PR:

- The Vomnibar is initialised when the `readyState` is "complete" (in
  the top frame only, and only if Vimium is enabled).  Requests arriving
  prior to then are silently discarded.
- The HUD is also initialized only when the `readyState` is "complete";
  however, requests arriving before then are queued.  So, if the user
  immediately enters insert mode, then the "Insert mode" indicator will
  eventually be displayed.
- The help dialog silently discards requests until the `readyState` is
  "complete.

I'm posting this as a PR because:

1. It needs some visibility.
2. With this, if the `readyState` *never* reaches "complete", then the
   Vomnibar would be unusable.  And that's pretty serious.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This fixes some UI component initialization issues.  It's a long
story...

The problem.

- Go to this page: http://www.thejournal.ie/seanad-election-results-2016-2737768-Apr2016/
- Click one of the links from the "Most Popular" box on the right.
- Navigate back (`H`) and, as the original page is loading, activate the Vomnibar.

In 1.54 this renders Vimium unusable.  In `master` this renders the
Vomnibar unsable, but the rest of Vimium usable.

It seems the source of the issue is that we're initializing UI
components too soon.  We need to wait until the `readyState` is
"complete".

With this PR:

- The Vomnibar is initialised when the `readyState` is "complete" (in
  the top frame only, and only if Vimium is enabled).  Requests arriving
  prior to then are silently discarded.
- The HUD is also initialized only when the `readyState` is "complete";
  however, requests arriving before then are queued.  So, if the user
  immediately enters insert mode, then the "Insert mode" indicator will
  eventually be displayed.
- The help dialog silently discards requests until the `readyState` is
  "complete.

I'm posting this as a PR because:

1. It needs some visibility.
2. With this, if the `readyState` *never* reaches "complete", then the
   Vomnibar would be unusable.  And that's pretty serious.
</pre>
</div>
</content>
</entry>
<entry>
<title>Make vimiumFlash a class.</title>
<updated>2016-04-28T05:51:35+00:00</updated>
<author>
<name>Stephen Blott</name>
</author>
<published>2016-04-28T05:51:35+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/vimium/commit/?id=fc8519e4e3a770253a35f1af7546d432f64392ea'/>
<id>fc8519e4e3a770253a35f1af7546d432f64392ea</id>
<content type='text'>
There are circumstances when we hav two (identical) vimiumFlash elements
displayed: specifically, when using the waitForEnter keyboard blocker.

So, we should use a class (rather than an id) to style the flash
element.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There are circumstances when we hav two (identical) vimiumFlash elements
displayed: specifically, when using the waitForEnter keyboard blocker.

So, we should use a class (rather than an id) to style the flash
element.
</pre>
</div>
</content>
</entry>
<entry>
<title>Improves next/previous links by targetting button elements and adding single left/right angle quotation marks</title>
<updated>2016-04-26T19:01:49+00:00</updated>
<author>
<name>Scott Pinkelman</name>
</author>
<published>2016-04-26T19:01:49+00:00</published>
<link rel='alternate' type='text/html' href='https://git.teddywing.com/fork/vimium/commit/?id=ee8c235aeaf52d2bc867a00c37731690e337c7ff'/>
<id>ee8c235aeaf52d2bc867a00c37731690e337c7ff</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
