vimium/content_scripts, branch 1.57 The hacker's browser. Merge pull request #2283 from smblott-github/fix-find-mode-hangs 2016-10-01T05:42:06+00:00 Stephen Blott 2016-10-01T05:42:06+00:00 53bc921af7d5ac96bc17754dcee5f2fe72ccde39 Find mode can hang Vimium (fixed). 
Find mode can hang Vimium (fixed).
 Fix find-mode hangs. 2016-10-01T05:25:00+00:00 Stephen Blott 2016-10-01T05:21:14+00:00 fb876164338e865144402689b159e4edf35cf777 "/" followed immediately by "i" can hang Vimium. The problem is that launching find mode is asynchronous (we wait until the HUD is available). Because normal mode is still active, we can enter insert mode *before* the find-mode HUD receives the focus. The result is that we end up in both find mode and insert mode, the HUD has the focus, but the HUD is in insert mode, so it ignores keyboard events (including `Escape`). The only way out is to click the page's body and then type `Escape`. This commit demonstrates the problem: 7d2b00411eae3293fa4c7b1f61b384c0c495b5a2. This happens in practice, for example while a busy page is loading. This commit fixes this by ensuring that find-mode blocks keyboard events immediately (and synchronously) on launch. 
"/" followed immediately by "i" can hang Vimium.

The problem is that launching find mode is asynchronous (we wait until
the HUD is available). Because normal mode is still active, we can enter
insert mode *before* the find-mode HUD receives the focus.

The result is that we end up in both find mode and insert mode, the HUD
has the focus, but the HUD is in insert mode, so it ignores keyboard
events (including `Escape`).

The only way out is to click the page's body and then type `Escape`.

This commit demonstrates the problem: 7d2b00411eae3293fa4c7b1f61b384c0c495b5a2.

This happens in practice, for example while a busy page is loading.

This commit fixes this by ensuring that find-mode blocks keyboard events
immediately (and synchronously) on launch.
Remove Coffeescript 1.10 dependency. 2016-09-30T14:32:22+00:00 Stephen Blott 2016-09-30T14:30:11+00:00 f6f4adfd95c34bb3beb5c42972623fe2acb39ec9 Fixes #2273. Fixes #2281. This fixes the build with Coffeescript 1.11, so we can remove the hard-wired dependency and notes. 
Fixes #2273.
Fixes #2281.

This fixes the build with Coffeescript 1.11, so we can remove the
hard-wired dependency and notes.
Use title attribute for link text. 2016-09-26T14:49:40+00:00 Stephen Blott 2016-09-26T14:49:36+00:00 6a14a480809e78c33034eac94b223b54dd35925a Google seems to be using a lot of "title" attributes on buttons. This makes it possible to type the text in filtered link-hints mode. (And you can often guess the text; e.g. "close"). We could also show the title text. That is very visually noisy though, in practice. 
Google seems to be using a lot of "title" attributes on buttons.  This
makes it possible to type the text in filtered link-hints mode.  (And
you can often guess the text; e.g. "close").

We could also show the title text.  That is very visually noisy though,
in practice.
Tweak jsaction detection and add tests. 2016-09-26T12:44:16+00:00 Stephen Blott 2016-09-26T12:44:16+00:00 afeb65f5af849f04df8380212dbf50a6bf186bc4 This tweaks the jsaction detection, in particular excluding elements where the "actionName" is "_". I see a lot of these, and clicking them doesn't do anything. Also, added corresponding tests. 
This tweaks the jsaction detection, in particular excluding elements
where the "actionName" is "_".  I see a lot of these, and clicking them
doesn't do anything.

Also, added corresponding tests.
Fix comment. 2016-09-26T04:08:30+00:00 Stephen Blott 2016-09-26T04:08:30+00:00 8c1957e600cff896b2a673d7ba8dbcaa132b37e5 Thinking about it more carefully, this algorithm is always O(n^2). 
Thinking about it more carefully, this algorithm is always O(n^2).
Active hint marker may be in another frame. 2016-09-25T16:08:00+00:00 Stephen Blott 2016-09-25T16:07:57+00:00 92477459341c1308ac48dad46617aea5de788089 Do not set the style on the active hint marker if it's in another frame. 
Do not set the style on the active hint marker if it's in another frame.
Reinstate highlighting of first hint. 2016-09-25T16:00:57+00:00 Stephen Blott 2016-09-25T16:00:57+00:00 6fafe8bc8057c90240b74b56d94707f4f1cd2968 Applies to filtered hints only. 
Applies to filtered hints only.
Do not reset tab index on modifiers. 2016-09-25T15:28:41+00:00 Stephen Blott 2016-09-25T15:28:39+00:00 e7c64d80d04c57da09b63e99a4b63396f3a96fcd The prevents the active element from being reset when we rotate hint markers. 
The prevents the active element from being reset when we rotate hint
markers.
Make tab-selected hint visible. 2016-09-25T15:09:17+00:00 Stephen Blott 2016-09-25T15:09:17+00:00 1b1b9c25e8b234598ff110dce7bb150f6d886169 When the user selects an active hint with Tab (for filtered hints), adjust its z-index such at it is top of the stack. 
When the user selects an active hint with Tab (for filtered hints),
adjust its z-index such at it is top of the stack.