vimium/background_scripts, branch 1.55

Handle in the same way as other special keys.

2016-05-15T08:05:21+00:00

Add a comment

2016-05-09T07:24:34+00:00

Fix link-hints failing to launch.

2016-05-07T03:19:46+00:00

Sometimes, link-hints mode fails to launch.  See Issue 1 from this post:
https://github.com/philc/vimium/issues/2081#issuecomment-210980903.

Here's a reproducible case:

- visit twitter
- using the vomnibar, visit any other page (in the same tab)
- hit `f` - the link hints fail to load.

What's happening is that the unregister/register frame messages for the
main/top frame arrive in the wrong order (first register, then
unregister).  Because these both have the same frame Id, the effect is
that the main/top frame ends up not registered.  So there are no
registered frames, so link hints mode doesn't launch.

Only the main/top frame has a re-usable frameId (`0`).  All other frames
receive a unique frame Id (which is never re-used).

Here, we just never unregister the main/top frame.  That way, it doesn't
matter which order the register/unregister messages arrive in.  If the
tab is navigating to a new page, then there'll be a new main/top frame
along soon.  If the tab is closing, then we tidy up in the
`chrome.tabs.onRemoved` handler.

Fix binary-search OOB.

2016-05-06T05:30:35+00:00

This affects binary search in the history cache.

The returned index can be one beyond the end of array, and so we get an
error when we look it up blindly.  So, we need to check.

Unregister frame port on onDisconnect.

2016-04-27T09:26:24+00:00

I seems that we cannot rely upon either the "unload" event in the
content script or the port's onDisconnect handler there to unregister
frames.

To see this, go to a frame-busy page like this one:

- https://www.theguardian.com/technology/2016/apr/26/apple-iphone-first-revenue-decline-13-years

and then navigate to any other simple page (in the same tab).  Navigate
back and forward with `H` and `L`.

If you watch frames registering anf unregistering, almost all of the
frames from the frame-busy page do not unregister.

Here, we unregister frames on onDisconnect in the background page too.

It is possible that this is the source of the problem mentioned as point
1 in this comment:

- https://github.com/philc/vimium/issues/2081#issuecomment-210980903

And for which #2116 is a workaround.

Help dialog; consistent ordering of commands.

2016-04-26T07:02:02+00:00

It reads weird on the helpd dialog if we don't put the full-page and
half-page commands in a similar order.

Help dialog; re-order and tweak command descriptions.

2016-04-26T05:46:53+00:00

- Re-order commands such that we keep like with like, and have the more
  important commands nearer the top.

- Re-word some command descriptions such that we use the same words for
  the the same thing consistently.

- Move "View Source" to the "Miscellaneous" category.

- Make some commands "advanced commands".

Help dialog; fix show-advanced-command button position.

2016-04-25T09:23:44+00:00

Show tip re. clicking command names.

2016-04-23T06:16:33+00:00

It's pretty undiscoverable that you can click command names to yank
them.  So, this adds a tip to the bottom of the help dialog.

Also, change the cursor to a pointer when hovering over command names.

Nicer styling of command names in help dialog.

2016-04-22T15:55:04+00:00

The commands names (in the help dialog) look nicer in italics.  They
also format better that way.