vimium/background_scripts, branch 1.42 The hacker's browser. Make the default value for scrollStepSize a string. 2012-10-28T09:15:56+00:00 Stephen Blott 2012-10-28T09:15:56+00:00 8ab335ad9b189881a19ecaa241361541690f6115 This interacts with these lines from settings.coffee: don't store the value if it is equal to the default, so we can change the defaults in the future if (value == @defaults[key]) @clear(key) If the default value is numeric, then this test NEVER succeeds (because "==" is compiled to "===", and the types don't match). So, scrollStepSize is stored in localStorage even if it has its default value. Which obviates the intention of the line quoted above. 
This interacts with these lines from settings.coffee:

    don't store the value if it is equal to the default, so we can change the defaults in the future
    if (value == @defaults[key])
      @clear(key)

If the default value is numeric, then this test NEVER succeeds (because
"==" is compiled to "===", and the types don't match).

So, scrollStepSize is stored in localStorage even if it has its default
value.  Which obviates the intention of the line quoted above.
Use insertCSS() API instead of manually created style element. 2012-10-24T19:33:56+00:00 Jez Ng 2012-10-24T19:33:56+00:00 647fd97bef55d2371e87f0cd418ddff62f36800e For some reason addCssToPage seemed to break on Chrome 24. Closes #676. 
For some reason addCssToPage seemed to break on Chrome 24.

Closes #676.
Code cleanup, as requested by in3/Jez Ng here: 2012-10-23T09:27:57+00:00 Stephen Blott 2012-10-23T09:27:57+00:00 c380cb5c9c8dd786b8203d2ed10d451da2ece2b7 - https://github.com/philc/vimium/pull/682. 
  - https://github.com/philc/vimium/pull/682.
Missed off one key line in previous commit. 2012-10-21T12:33:43+00:00 Stephen Blott 2012-10-21T12:33:43+00:00 5327ac1c0dedfd9f4d30e9a0bf626f9ffb962e2d 






Use block strings
2012-09-12T04:19:06+00:00

Darren Jeacocke

2012-09-12T04:19:06+00:00

d8e2de75544381e1f92389bad0faa060228d9ede












More lint fixes.
2012-09-10T00:40:54+00:00

Jez Ng

2012-09-10T00:40:54+00:00

99afbfc0018d078959e7bf36352771d9e9206338












Add more tests, and remove old settings code.
2012-09-09T20:47:35+00:00

Jez Ng

2012-09-09T20:46:12+00:00

44ed1848548d4c73c35c3302fc47ebfc8295dcae












Merge branch '1.39'
2012-09-09T19:02:13+00:00

Jez Ng

2012-09-09T19:02:13+00:00

b23cf23780864178ad77928409135eded02c4181












Fix default hint styling.
2012-09-09T05:01:16+00:00

Jez Ng

2012-09-09T05:01:16+00:00

5af3aafb649551115db1c871de0099cbf3d4e8eb












Merge branch 'next-release'
2012-09-08T20:37:05+00:00

Jez Ng

2012-09-08T20:37:05+00:00

adf8b7cc617279e50594477560ec7031e2ab68ea