From ac5b495929efed77f9bd954bd34a34b934d8da3b Mon Sep 17 00:00:00 2001 From: Elena Vilchik Date: Fri, 7 Jun 2019 14:40:01 +0200 Subject: Add parse error text and position to the log (#172) --- sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java | 3 ++- .../src/test/java/org/sonar/css/plugin/CssRuleSensorTest.java | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) (limited to 'sonar-css-plugin') diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java index a4f8c9a..2b268cd 100644 --- a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java +++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java @@ -219,7 +219,8 @@ public class CssRuleSensor implements Sensor { if (ruleKey == null) { if ("CssSyntaxError".equals(issue.rule)) { - LOG.error("Failed to parse " + inputFile.uri()); + String errorMessage = issue.text.replace("(CssSyntaxError)", "").trim(); + LOG.error("Failed to parse {}, line {}, {}", inputFile.uri(), issue.line, errorMessage); } else { LOG.error("Unknown stylelint rule or rule not enabled: '" + issue.rule + "'"); } diff --git a/sonar-css-plugin/src/test/java/org/sonar/css/plugin/CssRuleSensorTest.java b/sonar-css-plugin/src/test/java/org/sonar/css/plugin/CssRuleSensorTest.java index 6637617..df3d034 100644 --- a/sonar-css-plugin/src/test/java/org/sonar/css/plugin/CssRuleSensorTest.java +++ b/sonar-css-plugin/src/test/java/org/sonar/css/plugin/CssRuleSensorTest.java @@ -239,7 +239,7 @@ public class CssRuleSensorTest { CssRuleSensor sensor = createCssRuleSensor(rulesExecution); sensor.execute(context); - assertThat(logTester.logs(LoggerLevel.ERROR)).contains("Failed to parse " + inputFile.uri()); + assertThat(logTester.logs(LoggerLevel.ERROR)).contains("Failed to parse " + inputFile.uri() + ", line 2, Missed semicolon"); } @Test -- cgit v1.2.3