From 007084a29468d1ce2b3f5c772fd5adca0a5d5c4e Mon Sep 17 00:00:00 2001 From: Tibor Blenessy Date: Thu, 13 Sep 2018 16:27:09 +0200 Subject: Dont specifically handle InterruptedException (#129) --- .../java/org/sonar/css/plugin/CssRuleSensor.java | 24 ++++++++-------------- 1 file changed, 9 insertions(+), 15 deletions(-) (limited to 'sonar-css-plugin') diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java index a34b433..0e4f5fc 100644 --- a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java +++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRuleSensor.java @@ -104,22 +104,16 @@ public class CssRuleSensor implements Sensor { } } - private boolean isSuccessful(Process process) { - try { - int exitValue = process.waitFor(); - externalProcessStreamConsumer.await(); - // exit codes 0 and 2 are expected. 0 - means no issues were found, 2 - means that at least one "error-level" rule found issue - // see https://github.com/stylelint/stylelint/blob/master/docs/user-guide/cli.md#exit-codes - boolean isSuccessful = exitValue == 0 || exitValue == 2; - if (!isSuccessful) { - LOG.error("Analysis didn't terminate normally, please verify ERROR and WARN logs above. Exit code {}", exitValue); - } - return isSuccessful; - } catch (InterruptedException e) { - LOG.warn("InterruptedException while waiting for external process to finish", e); - Thread.currentThread().interrupt(); - return false; + private boolean isSuccessful(Process process) throws InterruptedException { + int exitValue = process.waitFor(); + externalProcessStreamConsumer.await(); + // exit codes 0 and 2 are expected. 0 - means no issues were found, 2 - means that at least one "error-level" rule found issue + // see https://github.com/stylelint/stylelint/blob/master/docs/user-guide/cli.md#exit-codes + boolean isSuccessful = exitValue == 0 || exitValue == 2; + if (!isSuccessful) { + LOG.error("Analysis didn't terminate normally, please verify ERROR and WARN logs above. Exit code {}", exitValue); } + return isSuccessful; } private boolean checkCompatibleNodeVersion(SensorContext context) { -- cgit v1.2.3