From 50e0ec766fe0aacb16f651571629b67910cabd95 Mon Sep 17 00:00:00 2001
From: Amaury Levé
Date: Tue, 26 Jun 2018 15:14:02 +0200
Subject: Rule S4668: Comments formatting should be valid

---
 .../main/java/org/sonar/css/plugin/CssRules.java   |  2 ++
 .../plugin/rules/NoInvalidDoubleSlashComments.java | 31 ++++++++++++++++++++++
 .../org/sonar/l10n/css/rules/css/S4668.html        | 11 ++++++++
 .../org/sonar/l10n/css/rules/css/S4668.json        | 16 +++++++++++
 .../l10n/css/rules/css/Sonar_way_profile.json      |  1 +
 5 files changed, 61 insertions(+)
 create mode 100644 sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/NoInvalidDoubleSlashComments.java
 create mode 100644 sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4668.html
 create mode 100644 sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4668.json

(limited to 'sonar-css-plugin/src')

diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java
index e05461b..a44da11 100644
--- a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java
+++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java
@@ -44,6 +44,7 @@ import org.sonar.css.plugin.rules.NoDuplicateAtImportRules;
 import org.sonar.css.plugin.rules.NoDuplicateSelectors;
 import org.sonar.css.plugin.rules.NoEmptySource;
 import org.sonar.css.plugin.rules.NoExtraSemicolons;
+import org.sonar.css.plugin.rules.NoInvalidDoubleSlashComments;
 import org.sonar.css.plugin.rules.PropertyNoUnknown;
 import org.sonar.css.plugin.rules.SelectorPseudoClassNoUnknown;
 import org.sonar.css.plugin.rules.SelectorPseudoElementNoUnknown;
@@ -83,6 +84,7 @@ public class CssRules {
       NoDuplicateSelectors.class,
       NoEmptySource.class,
       NoExtraSemicolons.class,
+      NoInvalidDoubleSlashComments.class,
       PropertyNoUnknown.class,
       SelectorPseudoClassNoUnknown.class,
       SelectorPseudoElementNoUnknown.class,
diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/NoInvalidDoubleSlashComments.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/NoInvalidDoubleSlashComments.java
new file mode 100644
index 0000000..9fcfd2d
--- /dev/null
+++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/NoInvalidDoubleSlashComments.java
@@ -0,0 +1,31 @@
+/*
+ * SonarCSS
+ * Copyright (C) 2018-2018 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+package org.sonar.css.plugin.rules;
+
+import org.sonar.check.Rule;
+
+@Rule(key = "S4668")
+public class NoInvalidDoubleSlashComments implements CssRule {
+
+  @Override
+  public String stylelintKey() {
+    return "no-invalid-double-slash-comments";
+  }
+}
diff --git a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4668.html b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4668.html
new file mode 100644
index 0000000..5c20c9d
--- /dev/null
+++ b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4668.html
@@ -0,0 +1,11 @@
+<p>The W3C specifications say comments should be defined using <code>/* ... */</code>. The use of <code>//</code> is not supported on all browsers and
+can lead to unexpected results.</p>
+<h2>Noncompliant Code Example</h2>
+<pre>
+a { // color: pink; }
+</pre>
+<h2>Compliant Solution</h2>
+<pre>
+a { /* color: pink; */ }
+</pre>
+
diff --git a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4668.json b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4668.json
new file mode 100644
index 0000000..981082e
--- /dev/null
+++ b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4668.json
@@ -0,0 +1,16 @@
+{
+  "title": "Comment formatting should be valid",
+  "type": "BUG",
+  "status": "ready",
+  "remediation": {
+    "func": "Constant\/Issue",
+    "constantCost": "1min"
+  },
+  "tags": [
+    
+  ],
+  "defaultSeverity": "Blocker",
+  "ruleSpecification": "RSPEC-4668",
+  "sqKey": "S4668",
+  "scope": "Main"
+}
diff --git a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json
index bc74edf..823c793 100644
--- a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json
+++ b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json
@@ -20,6 +20,7 @@
     "S4663",
     "S4666",
     "S4667",
+    "S4668",
     "S4670"
   ]
 }
-- 
cgit v1.2.3