From fd0139f0673ceaeabab4db3112cf18fff69f3c81 Mon Sep 17 00:00:00 2001 From: Elena Vilchik Date: Wed, 12 Jun 2019 11:53:55 +0200 Subject: Support stylelint report in different encoding (#176) --- .../sonar/css/plugin/StylelintReportSensorTest.java | 20 +++++++++++++++++++- .../resources/stylelint-report/report-utf16.json | Bin 0 -> 668 bytes .../resources/stylelint-report/report-utf8-bom.json | 17 +++++++++++++++++ 3 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 sonar-css-plugin/src/test/resources/stylelint-report/report-utf16.json create mode 100644 sonar-css-plugin/src/test/resources/stylelint-report/report-utf8-bom.json (limited to 'sonar-css-plugin/src/test') diff --git a/sonar-css-plugin/src/test/java/org/sonar/css/plugin/StylelintReportSensorTest.java b/sonar-css-plugin/src/test/java/org/sonar/css/plugin/StylelintReportSensorTest.java index 295cf7f..62974d9 100644 --- a/sonar-css-plugin/src/test/java/org/sonar/css/plugin/StylelintReportSensorTest.java +++ b/sonar-css-plugin/src/test/java/org/sonar/css/plugin/StylelintReportSensorTest.java @@ -71,7 +71,7 @@ public class StylelintReportSensorTest { } @Test - public void should_add_issues_from_report() throws Exception { + public void should_add_issues_from_report() { setReport("report.json"); stylelintReportSensor.execute(context); @@ -90,6 +90,24 @@ public class StylelintReportSensorTest { assertThat(first.primaryLocation().textRange().start().line()).isEqualTo(1); } + @Test + public void should_read_report_utf8_bom() { + setReport("report-utf8-bom.json"); + stylelintReportSensor.execute(context); + + Collection externalIssues = context.allExternalIssues(); + assertThat(externalIssues).hasSize(2); + } + + @Test + public void should_read_report_utf16() { + setReport("report-utf16.json"); + stylelintReportSensor.execute(context); + + Collection externalIssues = context.allExternalIssues(); + assertThat(externalIssues).hasSize(2); + } + @Test public void should_support_absolute_file_paths_in_report() throws Exception { String report = "[\n" + diff --git a/sonar-css-plugin/src/test/resources/stylelint-report/report-utf16.json b/sonar-css-plugin/src/test/resources/stylelint-report/report-utf16.json new file mode 100644 index 0000000..1fd449a Binary files /dev/null and b/sonar-css-plugin/src/test/resources/stylelint-report/report-utf16.json differ diff --git a/sonar-css-plugin/src/test/resources/stylelint-report/report-utf8-bom.json b/sonar-css-plugin/src/test/resources/stylelint-report/report-utf8-bom.json new file mode 100644 index 0000000..4f685c4 --- /dev/null +++ b/sonar-css-plugin/src/test/resources/stylelint-report/report-utf8-bom.json @@ -0,0 +1,17 @@ +[ + { + "source": "file.css", + "warnings": [ + { + "line": 1, + "rule": "color-no-invalid-hex", + "text": "external issue message (color-no-invalid-hex)" + }, + { + "line": 1, + "rule": "comment-no-empty", + "text": "external issue message (comment-no-empty)" + } + ] + } +] -- cgit v1.2.3