From ad92bb6746b5b29ce41f91f7aa6dc2bb8195fa07 Mon Sep 17 00:00:00 2001 From: Amaury Levé Date: Mon, 25 Jun 2018 14:31:23 +0200 Subject: Rule S4666: Selectors should not be duplicated --- .../resources/org/sonar/l10n/css/rules/css/S4666.html | 14 ++++++++++++++ .../resources/org/sonar/l10n/css/rules/css/S4666.json | 16 ++++++++++++++++ .../org/sonar/l10n/css/rules/css/Sonar_way_profile.json | 1 + 3 files changed, 31 insertions(+) create mode 100644 sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4666.html create mode 100644 sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4666.json (limited to 'sonar-css-plugin/src/main/resources') diff --git a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4666.html b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4666.html new file mode 100644 index 0000000..9521f64 --- /dev/null +++ b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4666.html @@ -0,0 +1,14 @@ +

When a selector appears more than once in a statement, this is not a bug but probably a mistake that reduces the readability of the source code. +Therefore, selectors should not be duplicated.

+

Noncompliant Code Example

+
+.foo,
+.bar,
+.foo {}
+
+

Compliant Solution

+
+.bar,
+.foo {}
+
+ diff --git a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4666.json b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4666.json new file mode 100644 index 0000000..f8be3d1 --- /dev/null +++ b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/S4666.json @@ -0,0 +1,16 @@ +{ + "title": "Selectors should not be duplicated", + "type": "CODE_SMELL", + "status": "ready", + "remediation": { + "func": "Constant\/Issue", + "constantCost": "1min" + }, + "tags": [ + + ], + "defaultSeverity": "Minor", + "ruleSpecification": "RSPEC-4666", + "sqKey": "S4666", + "scope": "Main" +} diff --git a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json index aa28914..079c18c 100644 --- a/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json +++ b/sonar-css-plugin/src/main/resources/org/sonar/l10n/css/rules/css/Sonar_way_profile.json @@ -14,6 +14,7 @@ "S4657", "S4658", "S4663", + "S4666", "S4667" ] } -- cgit v1.2.3