From 08d6560282dcd46710d7ad2db4ab8a4bb969e116 Mon Sep 17 00:00:00 2001 From: Amaury Levé Date: Fri, 22 Jun 2018 14:41:52 +0200 Subject: Rule S4655: '!important' should not be used on 'keyframes' (#61) --- .../main/java/org/sonar/css/plugin/CssRules.java | 12 +++++---- .../rules/KeyframeDeclarationNoImportant.java | 31 ++++++++++++++++++++++ 2 files changed, 38 insertions(+), 5 deletions(-) create mode 100644 sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/KeyframeDeclarationNoImportant.java (limited to 'sonar-css-plugin/src/main/java/org/sonar/css') diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java index 9e3a3b2..fe625d5 100644 --- a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java +++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/CssRules.java @@ -24,6 +24,7 @@ import org.sonar.api.batch.rule.Checks; import org.sonar.api.rule.RuleKey; import org.sonar.css.plugin.rules.CommentNoEmpty; import org.sonar.css.plugin.rules.CssRule; +import org.sonar.css.plugin.rules.KeyframeDeclarationNoImportant; import org.sonar.css.plugin.rules.NoEmptySource; import org.sonar.css.plugin.rules.ColorNoInvalidHex; import org.sonar.css.plugin.rules.StringNoNewline; @@ -54,11 +55,12 @@ public class CssRules { public static List getRuleClasses() { return Collections.unmodifiableList(Arrays.asList( - ColorNoInvalidHex.class, - CommentNoEmpty.class, - NoEmptySource.class, - StringNoNewline.class, - UnitNoUnknown.class + ColorNoInvalidHex.class, + CommentNoEmpty.class, + KeyframeDeclarationNoImportant.class, + NoEmptySource.class, + StringNoNewline.class, + UnitNoUnknown.class )); } diff --git a/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/KeyframeDeclarationNoImportant.java b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/KeyframeDeclarationNoImportant.java new file mode 100644 index 0000000..503f1ad --- /dev/null +++ b/sonar-css-plugin/src/main/java/org/sonar/css/plugin/rules/KeyframeDeclarationNoImportant.java @@ -0,0 +1,31 @@ +/* + * SonarCSS + * Copyright (C) 2018-2018 SonarSource SA + * mailto:info AT sonarsource DOT com + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 3 of the License, or (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public License + * along with this program; if not, write to the Free Software Foundation, + * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. + */ +package org.sonar.css.plugin.rules; + +import org.sonar.check.Rule; + +@Rule(key = "S4655") +public class KeyframeDeclarationNoImportant implements CssRule { + + @Override + public String stylelintKey() { + return "keyframe-declaration-no-important"; + } +} -- cgit v1.2.3