From b401bc78e686ba19219b3192280de2feee5b3845 Mon Sep 17 00:00:00 2001 From: Amaury Levé Date: Mon, 25 Jun 2018 11:05:10 +0200 Subject: Rule S1128: Useless imports should be removed (#64) --- its/plugin/projects/issues-project/src/file1.css | 5 ++++- its/plugin/projects/issues-project/src/file2.less | 5 ++++- its/plugin/projects/issues-project/src/file3.scss | 5 ++++- its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java | 4 +++- 4 files changed, 15 insertions(+), 4 deletions(-) (limited to 'its/plugin') diff --git a/its/plugin/projects/issues-project/src/file1.css b/its/plugin/projects/issues-project/src/file1.css index afd6213..34aa80c 100644 --- a/its/plugin/projects/issues-project/src/file1.css +++ b/its/plugin/projects/issues-project/src/file1.css @@ -1,3 +1,6 @@ +@import "a.css"; +@import "a.css"; /* S1128 | no-duplicate-at-import-rules */ + .class1 { background-color: #ffw; /* S4647 | color-no-invalid-hex */ width: 100pixels; /* S4653 | unit-no-unknown */ @@ -15,4 +18,4 @@ to { margin-top: 100px !important; /* S4655 | keyframe-declaration-no-important */ } -} +} \ No newline at end of file diff --git a/its/plugin/projects/issues-project/src/file2.less b/its/plugin/projects/issues-project/src/file2.less index afd6213..35a63f4 100644 --- a/its/plugin/projects/issues-project/src/file2.less +++ b/its/plugin/projects/issues-project/src/file2.less @@ -1,3 +1,6 @@ +@import 'a.css'; +@import 'a.css'; /* S1128 | no-duplicate-at-import-rules | Doesn't raise for LESS */ + .class1 { background-color: #ffw; /* S4647 | color-no-invalid-hex */ width: 100pixels; /* S4653 | unit-no-unknown */ @@ -15,4 +18,4 @@ to { margin-top: 100px !important; /* S4655 | keyframe-declaration-no-important */ } -} +} \ No newline at end of file diff --git a/its/plugin/projects/issues-project/src/file3.scss b/its/plugin/projects/issues-project/src/file3.scss index afd6213..22438ed 100644 --- a/its/plugin/projects/issues-project/src/file3.scss +++ b/its/plugin/projects/issues-project/src/file3.scss @@ -1,3 +1,6 @@ +@import 'a.css'; +@import 'a.css'; /* S1128 | no-duplicate-at-import-rules */ + .class1 { background-color: #ffw; /* S4647 | color-no-invalid-hex */ width: 100pixels; /* S4653 | unit-no-unknown */ @@ -15,4 +18,4 @@ to { margin-top: 100px !important; /* S4655 | keyframe-declaration-no-important */ } -} +} \ No newline at end of file diff --git a/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java b/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java index d70597d..adfbe11 100644 --- a/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java +++ b/its/plugin/src/test/java/org/sonar/css/its/IssuesTest.java @@ -50,7 +50,9 @@ public class IssuesTest { request.setComponentKeys(Collections.singletonList(PROJECT_KEY)); List issuesList = newWsClient().issues().search(request).getIssuesList(); - assertThat(issuesList).extracting("rule").hasSize(CssRules.getRuleClasses().size() * 3); + assertThat(issuesList).extracting("rule").hasSize( + CssRules.getRuleClasses().size() * 3 + - 1 /* issue S1128 not raised on .less */); } } -- cgit v1.2.3